Skip to content

Add Binary data type #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 8, 2021
Merged

Add Binary data type #703

merged 4 commits into from
Sep 8, 2021

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented Sep 8, 2021

As titled.

Closes: #656.

@delvedor delvedor requested a review from a team September 8, 2021 07:05
@delvedor
Copy link
Member Author

delvedor commented Sep 8, 2021

I've changed our initial idea of using a marker Binary class as it was confusing in the resulting json output. I've updated the compiler to accept the native typescript ArrayBuffer type and output an internal custom binary type.

swallez
swallez approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delvedor delvedor merged commit 169b83c into main Sep 8, 2021
@delvedor delvedor deleted the feat-656 branch September 8, 2021 07:58
github-actions bot pushed a commit that referenced this pull request Sep 8, 2021
@delvedor @github-actions
Add Binary data type (#703)
27d319a
@github-actions github-actions bot mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swallez swallez swallez approved these changes

Assignees
No one assigned
Labels
compiler generator:typescript specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Binary data type
2 participants
@delvedor @swallez