Skip to content

Add more fine grained security privileges definition #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2021

Conversation

delvedor
Copy link
Member

As titled.

@delvedor delvedor requested a review from a team September 10, 2021 07:27
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but wouldn't it makes sense to have ClusterPrivilege and IndexPrivilege in one file called Privileges ?

@delvedor
Copy link
Member Author

Good call @philkra, done.

Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@delvedor delvedor merged commit e27bfcd into main Sep 10, 2021
@delvedor delvedor deleted the security-privileges branch September 10, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants