Skip to content

Commit b6f20ff

Browse files
authored
Increase timeout for ensureGreen in testDownsampleIndexWithRollingRestart (#105277)
1 parent e489951 commit b6f20ff

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

x-pack/plugin/downsample/src/internalClusterTest/java/org/elasticsearch/xpack/downsample/DownsampleClusterDisruptionIT.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public void run() {
109109
.getNodes()[0].getName();
110110
logger.info("Candidate node [" + candidateNode + "]");
111111
disruption.accept(candidateNode);
112-
ensureGreen(sourceIndex);
112+
ensureGreen(TimeValue.timeValueSeconds(60), sourceIndex);
113113
ensureStableCluster(cluster.numDataAndMasterNodes(), clientNode);
114114

115115
} catch (Exception e) {
@@ -208,7 +208,6 @@ public boolean validateClusterForming() {
208208
assertTargetIndex(cluster, sourceIndex, targetIndex, indexedDocs);
209209
}
210210

211-
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/100653")
212211
public void testDownsampleIndexWithRollingRestart() throws Exception {
213212
final InternalTestCluster cluster = internalCluster();
214213
final List<String> masterNodes = cluster.startMasterOnlyNodes(1);

x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/TransportDownsampleAction.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -960,11 +960,11 @@ public void onResponse(final AcknowledgedResponse response) {
960960
.indices()
961961
.forceMerge(request, ActionListener.wrap(mergeIndexResp -> actionListener.onResponse(AcknowledgedResponse.TRUE), t -> {
962962
/*
963-
* At this point downsampel index has been created
964-
* successfully even force merge fails.
965-
* So, we should not fail the downsample operation
963+
* At this point downsample index has been created
964+
* successfully even if force merge failed.
965+
* So, we should not fail the downsample operation.
966966
*/
967-
logger.error("Failed to force-merge " + "downsample index [" + downsampleIndexName + "]", t);
967+
logger.error("Failed to force-merge downsample index [" + downsampleIndexName + "]", t);
968968
actionListener.onResponse(AcknowledgedResponse.TRUE);
969969
}));
970970
}

0 commit comments

Comments
 (0)