Skip to content

[DOCS] Replaces X-Pack security terminology #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2019

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 23, 2019

Related to elastic/docs#407
This PR replaces occurrences of {security} or "X-Pack Security" with the new {security-features}, {stack-security-features}, or {es-security-features} terminology.

Copy link
Contributor

@tvernum tvernum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a couple of suggestions

Authorization is the process of determining whether the user behind an incoming
request is allowed to execute the request.
The {stack-security-features} introduce the concept of _authorization_ to the
{stack}. Authorization is the process of determining whether the user behind an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The repeated use of "stack" feels a little off. We may need to phrase this quite differently if we to avoid describing {security} as being something extra that's added to the stack.
Maybe:

The {stack-security-features} include support for the concept of _authorization_.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tvernum , I change it to: "The {stack-security-features} add authorization, which is the process of determining whether the user..."

@lcawl lcawl merged commit ce0494c into elastic:master Mar 4, 2019
@lcawl lcawl deleted the xpack-security branch March 4, 2019 23:33
lcawl added a commit that referenced this pull request Mar 4, 2019
lcawl added a commit that referenced this pull request Mar 4, 2019
lcawl added a commit that referenced this pull request Mar 4, 2019
lcawl added a commit that referenced this pull request Mar 4, 2019
lcawl added a commit that referenced this pull request Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants