Skip to content

Add secops guides for network and hosts #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2019
Merged

Conversation

karenzone
Copy link
Contributor

@karenzone karenzone commented Mar 20, 2019

Continuation from #189

@nik9000
Copy link
Member

nik9000 commented Mar 20, 2019

The PR tests here found something but they didn't log things very well......

@karenzone
Copy link
Contributor Author

karenzone commented Mar 22, 2019

@elastic/secops I've updated the docs framework to give you two books (network and hosts) based on comments from @andrewkroh in #189. Picturing a new book based on asciidoc files can be tough, so

DeDe wrote our first solution guide for Infrastructure (https://www.elastic.co/guide/en/infrastructure/guide/current/index.html). Her guide has a nice user-centered flow to it, and I've followed her info architecture in these new security guides.

We'll also need to add some info similar to this to the Kibana Reference.

@tsg
Copy link

tsg commented Mar 22, 2019

@karenzone I've noticed a .DS_store file in the PR, you should remove that.

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure seems good. Not sure what's causing the test failure.

@nik9000
Copy link
Member

nik9000 commented Mar 25, 2019

Since this test is a new one from me I'll see what I can find locally.

@nik9000
Copy link
Member

nik9000 commented Mar 25, 2019

OK! The tests are failing because your PR is quite out of date with master and it is missing some files that it needs to run the tests, specifically it is missing the "installation and upgrade guide". Merging mater into this branch ought to fix it. I'll improve the error message in the mean time.

Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That merge did the trick!

@karenzone karenzone merged commit e26a27e into elastic:master Apr 2, 2019
@karenzone karenzone deleted the hostmon branch April 17, 2019 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants