CR comments

Author: biscout42

libs/go-kibana-rest/docker-compose.yml

@@ -24,14 +24,13 @@ services:
         condition: service_started
   kibana:
     image: docker.elastic.co/kibana/kibana:8.14.3
-    volumes:
-      - ./kibana.yml:/usr/share/kibana/config/kibana.yml
     environment:
       ELASTICSEARCH_HOSTS: http://es:9200
       ELASTICSEARCH_USERNAME: kibana_system
       ELASTICSEARCH_PASSWORD: changeme
       xpack.security.http.ssl.enabled: false
       xpack.license.self_generated.type: trial
+      XPACK_ENCRYPTEDSAVEDOBJECTS_ENCRYPTIONKEY: min-32-byte-long-strong-encryption-key
     links:
       - elasticsearch:es
     ports:

libs/go-kibana-rest/kbapi/api.kibana_synthetics.go

@@ -73,13 +73,13 @@ type KibanaSyntheticsPrivateLocationAPI struct {
 	Get    KibanaSyntheticsPrivateLocationGet
 }
 
+type SyntheticsStatusConfig struct {
+	Enabled *bool `json:"enabled,omitempty"`
+}
+
 type MonitorAlertConfig struct {
-	Status struct {
-		Enabled *bool `json:"enabled,omitempty"`
-	} `json:"status,omitempty"`
-	Tls struct {
-		Enabled *bool `json:"enabled,omitempty"`
-	} `json:"tls,omitempty"`
+	Status SyntheticsStatusConfig `json:"status,omitempty"`
+	Tls    SyntheticsStatusConfig `json:"tls,omitempty"`
 }
 
 type HTTPMonitorFields struct {
@@ -119,14 +119,16 @@ type MonitorScheduleConfig struct {
 	Unit   string `json:"unit"`
 }
 
+type SyntheticGeoConfig struct {
+	Lat float64 `json:"lat"`
+	Lon float64 `json:"lon"`
+}
+
 type MonitorLocationConfig struct {
-	Id    string `json:"id"`
-	Label string `json:"label"`
-	Geo   struct {
-		Lat float64 `json:"lat"`
-		Lon float64 `json:"lon"`
-	} `json:"geo"`
-	IsServiceManaged bool `json:"isServiceManaged"`
+	Id               string              `json:"id"`
+	Label            string              `json:"label"`
+	Geo              *SyntheticGeoConfig `json:"geo,omitempty"`
+	IsServiceManaged bool                `json:"isServiceManaged"`
 }
 
 type SyntheticsMonitor struct {
@@ -161,16 +163,11 @@ type SyntheticsMonitor struct {
 	} `json:"__ui,omitempty"`
 }
 
-type Geo struct {
-	Lat float32 `json:"lat"`
-	Lon float32 `json:"lon"`
-}
-
 type PrivateLocationConfig struct {
-	Label         string   `json:"label"`
-	AgentPolicyId string   `json:"agentPolicyId"`
-	Tags          []string `json:"tags,omitempty"`
-	Geo           Geo      `json:"geo,omitempty"`
+	Label         string              `json:"label"`
+	AgentPolicyId string              `json:"agentPolicyId"`
+	Tags          []string            `json:"tags,omitempty"`
+	Geo           *SyntheticGeoConfig `json:"geo,omitempty"`
 }
 
 type PrivateLocation struct {

libs/go-kibana-rest/kbapi/api.kibana_synthetics_test.go

@@ -123,7 +123,7 @@ func (s *KBAPITestSuite) TestKibanaSyntheticsPrivateLocationAPI() {
 					Label:         fmt.Sprintf("TestKibanaSyntheticsPrivateLocationAPI %s", testUuid),
 					AgentPolicyId: policyId,
 					Tags:          []string{"a", "b"},
-					Geo: Geo{
+					Geo: &SyntheticGeoConfig{
 						Lat: 12.12,
 						Lon: -42.42,
 					},