Fixup error handling during saved object imports

Author: tobio

internal/kibana/import_saved_objects/create.go

@@ -2,6 +2,8 @@ package import_saved_objects
 
 import (
 	"context"
+	"fmt"
+	"strings"
 
 	"github.com/google/uuid"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
@@ -71,7 +73,23 @@ func (r *Resource) importObjects(ctx context.Context, plan tfsdk.Plan, state *tf
 	}
 
 	if !respModel.Success && !model.IgnoreImportErrors.ValueBool() {
-		diags.AddError("not all objects were imported successfully", "see errors attribute for more details")
+		var detail strings.Builder
+		for i, err := range respModel.Errors {
+			detail.WriteString(fmt.Sprintf("import error [%d]: %s\n", i, err))
+		}
+		detail.WriteString("see the `errors` attribute for the full resposne")
+
+		if respModel.SuccessCount > 0 {
+			diags.AddWarning(
+				"not all objects were imported successfully",
+				detail.String(),
+			)
+		} else {
+			diags.AddError(
+				"no objects imported successfully",
+				detail.String(),
+			)
+		}
 	}
 }
 
@@ -90,15 +108,24 @@ type importSuccess struct {
 }
 
 type importError struct {
-	ID    string          `json:"id"`
-	Type  string          `json:"type"`
-	Title string          `json:"title"`
-	Error importErrorType `json:"error"`
-	Meta  importMeta      `json:"meta"`
+	ID    string          `tfsdk:"id" json:"id"`
+	Type  string          `tfsdk:"type" json:"type"`
+	Title string          `tfsdk:"title" json:"title"`
+	Error importErrorType `tfsdk:"error" json:"error"`
+	Meta  importMeta      `tfsdk:"meta" json:"meta"`
+}
+
+func (ie importError) String() string {
+	title := ie.Title
+	if title == "" {
+		title = ie.Meta.Title
+	}
+
+	return fmt.Sprintf("[%s] error on [%s] with ID [%s] and title [%s]", ie.Error.Type, ie.Type, ie.ID, title)
 }
 
 type importErrorType struct {
-	Type string `json:"type"`
+	Type string `tfsdk:"type" json:"type"`
 }
 
 type importMeta struct {