Suggestions apply

Author: jdesnoes

CHANGELOG.md

@@ -1,5 +1,7 @@
 ## [Unreleased]
 
+- Add `elasticstack_kibana_spaces` data source ([#682](https://github.com/elastic/terraform-provider-elasticstack/pull/682))
+
 ## [0.11.5] - 2024-08-12
 
 - Fix setting `id` for Fleet outputs and servers ([#666](https://github.com/elastic/terraform-provider-elasticstack/pull/666))

internal/kibana/spaces/data_source.go

@@ -10,7 +10,6 @@ import (
 
 // Ensure the implementation satisfies the expected interfaces.
 var (
-	_ datasource.DataSource              = &dataSource{}
 	_ datasource.DataSource              = &dataSource{}
 	_ datasource.DataSourceWithConfigure = &dataSource{}
 )

internal/kibana/spaces/read.go

@@ -29,13 +29,14 @@ func (d *dataSource) Read(ctx context.Context, req datasource.ReadRequest, resp
 			ImageUrl:    types.StringValue(space.ImageURL),
 		}
 
-		if disabledFeatures, diags := types.ListValueFrom(ctx, types.StringType, space.DisabledFeatures); diags.HasError() {
+		disabledFeatures, diags := types.ListValueFrom(ctx, types.StringType, space.DisabledFeatures)
+		if diags.HasError() {
 			resp.Diagnostics.Append(diags...)
 			return
-		} else {
-			spaceState.DisabledFeatures = disabledFeatures
 		}
 
+		spaceState.DisabledFeatures = disabledFeatures
+
 		state.Spaces = append(state.Spaces, spaceState)
 	}