Skip to content

Commit 017c9da

Browse files
feat: take moduleVersion as a CLI parameter instead of inferring
BREAKING CHANGE: The new moduleVersion CLI paramater is required, the module version will no longer be automatically inferred when using the CLI
1 parent 7c78f6c commit 017c9da

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

src/bin.ts

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const args = minimist(process.argv, {
1515
},
1616
});
1717

18-
const { dir, outDir, useReadme, packageMode, help } = args;
18+
const { dir, outDir, useReadme, packageMode, moduleVersion, help } = args;
1919
if (!['single', 'multi'].includes(packageMode)) {
2020
console.error(chalk.red('packageMode must be one of "single" and "multi"'));
2121
process.exit(1);
@@ -35,22 +35,17 @@ if (typeof dir !== 'string') {
3535
process.exit(1);
3636
}
3737

38-
const resolvedDir = path.isAbsolute(dir) ? dir : path.resolve(process.cwd(), dir);
39-
if (!fs.pathExistsSync(resolvedDir)) {
40-
runner.fail(`${chalk.red('Resolved directory does not exist:')} ${chalk.cyan(resolvedDir)}`);
38+
if (typeof moduleVersion !== 'string') {
39+
runner.fail(chalk.red('Missing required --moduleVersion argument. "--moduleVersion 1.2.3"'));
4140
process.exit(1);
4241
}
4342

44-
const packageJsonPath = path.resolve(resolvedDir, 'package.json');
45-
if (!fs.pathExistsSync(packageJsonPath)) {
46-
runner.fail(
47-
`${chalk.red('Expected a package.json file to exist at path:')} ${chalk.cyan(packageJsonPath)}`,
48-
);
43+
const resolvedDir = path.isAbsolute(dir) ? dir : path.resolve(process.cwd(), dir);
44+
if (!fs.pathExistsSync(resolvedDir)) {
45+
runner.fail(`${chalk.red('Resolved directory does not exist:')} ${chalk.cyan(resolvedDir)}`);
4946
process.exit(1);
5047
}
5148

52-
const pj = require(packageJsonPath);
53-
5449
const resolvedOutDir =
5550
typeof outDir === 'string'
5651
? path.isAbsolute(outDir)
@@ -66,7 +61,7 @@ fs.mkdirp(resolvedOutDir).then(() =>
6661
parseDocs({
6762
useReadme: useReadme ? true : false,
6863
baseDirectory: resolvedDir,
69-
moduleVersion: pj.version,
64+
moduleVersion,
7065
packageMode,
7166
})
7267
.then(data =>

0 commit comments

Comments
 (0)