Skip to content

Add drum/joke reaction #3217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: livekit
Choose a base branch
from
Open

Add drum/joke reaction #3217

wants to merge 4 commits into from

Conversation

davidegirardi
Copy link
Contributor

Underline the awesome joke someone just said in the call with a twist on a classic punchline drum fill.

@davidegirardi davidegirardi requested a review from a team as a code owner April 17, 2025 06:55
@davidegirardi davidegirardi requested a review from robintown April 17, 2025 06:55
@CLAassistant
Copy link

CLAassistant commented Apr 17, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as long as product is happy with this (@fkwp)

@@ -23,3 +23,4 @@ The following sound effects have been originally created by Element.
- `end_call`
- `reactions/rock`
- `reactions/wave`
- `reactions/baduntss`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you record this on your own drum kit? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. I played on a MIDI controller to trigger samples.

@robintown robintown added X-Blocked Cannot be merged due to external dependencies and removed X-Blocked Cannot be merged due to external dependencies labels May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Feature Release note category. A PR that introduces a new user facing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants