Boot in interactive mode before system reboot

Author: josevalim

lib/mix/lib/mix/tasks/release.ex

@@ -655,12 +655,13 @@ defmodule Mix.Tasks.Release do
       so you can configure system applications, such as `:kernel` and `:stdlib`,
       in your `config/runtime.exs`. Generally speaking, it is best to configure
       `:kernel` and `:stdlib` using the `vm.args` file but this option is available
-      for those who need more complex configuration. When set to `true` the computed
-      config file will be written to the "tmp" directory inside the release every time
-      the system boots. You can configure the "tmp" directory by setting the
-      `RELEASE_TMP` environment variable, either explicitly or inside your
-      `releases/RELEASE_VSN/env.sh` (or `env.bat` on Windows). Defaults to `true`
-      if using the deprecated `config/releases.exs`, `false` otherwise.
+      for those who need more complex configuration. When set to `true`, the
+      release will first boot in interactive mode to compute a config file and
+      write it to the "tmp" directory. Then it reboots in the configured `RELEASE_MODE`.
+      You can configure the "tmp" directory by setting the `RELEASE_TMP` environment
+      variable, either explicitly or inside your `releases/RELEASE_VSN/env.sh`
+      (or `env.bat` on Windows). Defaults to `true` if using the deprecated
+      `config/releases.exs`, `false` otherwise.
 
     * `:prune_runtime_sys_config_after_boot` - if `:reboot_system_after_config`
       is set, every time your system boots, the release will write a config file
@@ -1037,6 +1038,7 @@ defmodule Mix.Tasks.Release do
     Mix.Project.get!()
     Mix.Task.run("compile", args)
     Mix.ensure_application!(:sasl)
+    Mix.ensure_application!(:crypto)
 
     config = Mix.Project.config()
 
@@ -1098,7 +1100,7 @@ defmodule Mix.Tasks.Release do
     # releases/
     #   COOKIE
     #   start_erl.data
-    consolidation_path = build_rel(release, config)
+    {consolidation_path, release} = build_rel(release, config)
 
     [
       # erts-VSN/
@@ -1203,7 +1205,7 @@ defmodule Mix.Tasks.Release do
          :ok <- Mix.Release.make_sys_config(release, sys_config, config_provider_path),
          :ok <- Mix.Release.make_cookie(release, cookie_path),
          :ok <- Mix.Release.make_start_erl(release, start_erl_path) do
-      consolidation_path
+      {consolidation_path, release}
     else
       {:error, message} ->
         File.rm_rf!(version_path)
@@ -1471,7 +1473,7 @@ defmodule Mix.Tasks.Release do
     reboot? = Keyword.get(release.options, :reboot_system_after_config, false)
 
     if reboot? and release.config_providers != [] do
-      "-elixir -config_provider_reboot_mode #{env_var}"
+      "-elixir config_provider_reboot_mode #{env_var}"
     else
       "-mode #{env_var}"
     end

lib/mix/test/mix/release_test.exs

@@ -18,6 +18,7 @@ defmodule Mix.ReleaseTest do
 
   setup_all do
     Mix.ensure_application!(:sasl)
+    Mix.ensure_application!(:crypto)
     :ok
   end
 

lib/mix/test/mix/tasks/release_test.exs

@@ -386,7 +386,8 @@ defmodule Mix.Tasks.ReleaseTest do
         config :release_test, :runtime,
           override: :runtime,
           config_env: config_env(),
-          config_target: config_target()
+          config_target: config_target(),
+          mode: :code.get_mode()
 
         config :release_test, :encoding, {:runtime, :_μ, :"£", "£", '£'}
         """)
@@ -425,7 +426,13 @@ defmodule Mix.Tasks.ReleaseTest do
                  release_vsn: "0.1.0",
                  runtime_config:
                    {:ok,
-                    [keep: :static, override: :runtime, config_env: :dev, config_target: :host]},
+                    [
+                      keep: :static,
+                      override: :runtime,
+                      config_env: :dev,
+                      config_target: :host,
+                      mode: :interactive
+                    ]},
                  static_config: {:ok, :was_set},
                  sys_config_env: sys_config_env,
                  sys_config_init: sys_config_init
@@ -581,6 +588,7 @@ defmodule Mix.Tasks.ReleaseTest do
         File.write!("config/runtime.exs", """
         import Config
         config :release_test, :static, String.to_atom(System.get_env("RELEASE_STATIC"))
+        config :release_test, :runtime, mode: :code.get_mode()
         """)
 
         root = Path.absname("_build/dev/rel/no_compile_env_config")
@@ -589,7 +597,13 @@ defmodule Mix.Tasks.ReleaseTest do
         # It boots with mismatched config
         env = [{~c"RELEASE_STATIC", ~c"runtime"}]
         open_port(Path.join(root, "bin/no_compile_env_config"), [~c"start"], env)
-        assert %{} = wait_until_decoded(Path.join(root, "RELEASE_BOOTED"))
+
+        assert %{
+                 mode: :embedded,
+                 runtime_config: {:ok, [mode: :embedded]},
+                 static_config: {:ok, :runtime}
+               } =
+                 wait_until_decoded(Path.join(root, "RELEASE_BOOTED"))
       end)
     end)
   end
@@ -643,7 +657,7 @@ defmodule Mix.Tasks.ReleaseTest do
       Mix.Project.in_project(:release_test, ".", config, fn _ ->
         File.write!("config/runtime.exs", """
         import Config
-        config :release_test, :runtime, :was_set
+        config :release_test, :runtime, [mode: :code.get_mode()]
         """)
 
         root = Path.absname("_build/dev/rel/eval")
@@ -676,7 +690,7 @@ defmodule Mix.Tasks.ReleaseTest do
                  release_prog: "eval" <> ext,
                  release_root: release_root,
                  release_vsn: "0.1.0",
-                 runtime_config: {:ok, :was_set},
+                 runtime_config: {:ok, [mode: :interactive]},
                  static_config: {:ok, :was_set}
                } = wait_until_decoded(Path.join(root, "RELEASE_BOOTED"))
 

lib/mix/test/mix_test.exs

@@ -339,8 +339,14 @@ defmodule MixTest do
       on_exit(fn ->
         :code.set_path(path)
         purge([InstallTest, InstallTest.MixProject, InstallTest.Protocol])
-        Application.stop(:install_test)
-        Application.unload(:install_test)
+
+        ExUnit.CaptureLog.capture_log(fn ->
+          Application.stop(:git_repo)
+          Application.unload(:git_repo)
+
+          Application.stop(:install_test)
+          Application.unload(:install_test)
+        end)
       end)
 
       Mix.State.put(:installed, nil)