Skip to content

Add more information to anonymous rescue hint #13641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2024
Merged

Add more information to anonymous rescue hint #13641

merged 1 commit into from
Jun 6, 2024

Conversation

sabiwara
Copy link
Contributor

@sabiwara sabiwara commented Jun 6, 2024 •
edited
Loading

This hint should help users fixing these warning, like this one.

Screenshot 2024-06-06 at 10 36 05

Sample code which can trigger the issue:

  def inverse(x) do
    1 / x
  rescue
    err -> err.message
  end

@sabiwara
Copy link
Contributor Author

sabiwara commented Jun 6, 2024

Note: to be backported if merged.

josevalim
josevalim approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@josevalim josevalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please backport!

@sabiwara sabiwara merged commit cabd7d8 into elixir-lang:main Jun 6, 2024
9 checks passed
@sabiwara sabiwara deleted the anonymous-rescue-hint branch June 6, 2024 12:15
sabiwara added a commit to sabiwara/elixir that referenced this pull request Jun 6, 2024
@sabiwara
Add more information to anonymous rescue hint (elixir-lang#13641)
125d555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabiwara @josevalim