Skip to content

Commit 6925dae

Browse files
committed
Revert "Rename latestVersion to isStale and use boolean"
This reverts commit 8ef47f0.
1 parent da05c1d commit 6925dae

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

assets/js/handlebars/templates/versions-dropdown.handlebars

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
<label>
33
<span class="sidebar-projectVersionsDropdownCaret" aria-hidden="true">&#x25bc;</span>
44
<span class="sr-only">Project version</span>
5-
{{#if isStale}}
5+
{{#if latestVersion}}
66
<i class="ri-alert-line sidebar-staleIcon" aria-hidden="true"></i>
77
<span class="sr-only">This version is not the latest version of the package</span>
88
{{/if}}
9-
<select class="sidebar-projectVersionsDropdown{{#if isStale}} sidebar-staleVersion{{/if}}"{{#if isStale}} title="This version is not the latest version of the package"{{/if}}>
9+
<select class="sidebar-projectVersionsDropdown{{#if latestVersion}} sidebar-staleVersion{{/if}}"{{#if latestVersion}} title="This version is not the latest version of the package."{{/if}}>
1010
{{#each nodes}}
1111
<option translate="no" value="{{url}}"{{#if isCurrentVersion}} selected disabled{{/if}}>
1212
{{version}}

assets/js/sidebar/sidebar-version-select.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,17 @@ export function initialize () {
1717
const currentVersion = versionsContainer.textContent.trim()
1818

1919
const latestVersionNode = versionNodes.find(node => node.latest)
20-
const isStale = latestVersionNode?.version !== currentVersion
20+
const latestVersion = latestVersionNode?.version !== currentVersion ? latestVersionNode?.version : null
2121

2222
const nodes = decorateVersionNodes(versionNodes, currentVersion)
2323

24-
renderVersionsDropdown({ nodes, isStale })
24+
renderVersionsDropdown({ nodes, latestVersion })
2525
}
2626
}
2727

28-
function renderVersionsDropdown ({ nodes, isStale }) {
28+
function renderVersionsDropdown ({ nodes, latestVersion }) {
2929
const versionsContainer = qs(VERSIONS_CONTAINER_SELECTOR)
30-
const versionsDropdownHtml = versionsDropdownTemplate({ nodes, isStale })
30+
const versionsDropdownHtml = versionsDropdownTemplate({ nodes, latestVersion })
3131
versionsContainer.innerHTML = versionsDropdownHtml
3232

3333
qs(VERSIONS_DROPDOWN_SELECTOR).addEventListener('change', handleVersionSelected)

0 commit comments

Comments
 (0)