Skip to content

Commit 849b01c

Browse files
committed
Revert "Adjust select width"
This reverts commit 5835e2e.
1 parent 9f87941 commit 849b01c

File tree

3 files changed

+1
-38
lines changed

3 files changed

+1
-38
lines changed

assets/css/sidebar.css

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -125,16 +125,6 @@
125125
top: 3px;
126126
}
127127

128-
.sidebar-versionsLabel {
129-
position: relative;
130-
cursor: pointer;
131-
}
132-
133-
.sidebar-versionsText {
134-
padding: 0 0 0 12px;
135-
color: var(--sidebarMuted);
136-
}
137-
138128
.sidebar .sidebar-list-nav {
139129
display: flex;
140130
margin: 0;

assets/js/handlebars/templates/versions-dropdown.handlebars

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
<label>
33
<span class="sidebar-projectVersionsDropdownCaret" aria-hidden="true">&#x25bc;</span>
44
<span class="sr-only">Project version</span>
5-
<span class="sidebar-versionsText"></span>
6-
<select class="sidebar-projectVersionsDropdown" hidden>
5+
<select class="sidebar-projectVersionsDropdown">
76
{{#each nodes}}
87
<option translate="no" value="{{url}}"{{#if isCurrentVersion}} selected disabled{{/if}}>
98
{{version}}

assets/js/sidebar/sidebar-version-select.js

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import versionsDropdownTemplate from '../handlebars/templates/versions-dropdown.
44

55
const VERSIONS_CONTAINER_SELECTOR = '.sidebar-projectVersion'
66
const VERSIONS_DROPDOWN_SELECTOR = '.sidebar-projectVersionsDropdown'
7-
const VERSIONS_TEXT_SELECTOR = '.sidebar-versionsText'
87

98
/**
109
* Initializes selectable version list if `versionNodes` have been configured.
@@ -23,22 +22,9 @@ export function initialize () {
2322
const nodes = decorateVersionNodes(versionNodes, currentVersion)
2423

2524
renderVersionsDropdown({ nodes, latestVersion })
26-
initializeVersionSelect()
2725
}
2826
}
2927

30-
function initializeVersionSelect () {
31-
const select = qs(VERSIONS_DROPDOWN_SELECTOR)
32-
const text = qs(VERSIONS_TEXT_SELECTOR)
33-
34-
text.textContent = select.options[select.selectedIndex].text
35-
36-
text.addEventListener('click', (event) => {
37-
if (event.target === select) return
38-
openVersionSelect()
39-
})
40-
}
41-
4228
function renderVersionsDropdown ({ nodes, latestVersion }) {
4329
const versionsContainer = qs(VERSIONS_CONTAINER_SELECTOR)
4430
const versionsDropdownHtml = versionsDropdownTemplate({ nodes, latestVersion })
@@ -98,18 +84,6 @@ function handleVersionSelected (event) {
9884
*/
9985
export function openVersionSelect () {
10086
const select = qs(VERSIONS_DROPDOWN_SELECTOR)
101-
const text = qs(VERSIONS_TEXT_SELECTOR)
102-
103-
select.hidden = false
104-
text.hidden = true
105-
106-
const hideSelect = () => {
107-
select.hidden = true
108-
text.hidden = false
109-
select.removeEventListener('blur', hideSelect)
110-
}
111-
112-
select.addEventListener('blur', hideSelect)
11387

11488
if (select) {
11589
select.focus()

0 commit comments

Comments
 (0)