reinstall log handler after loading config

Author: lukaszsamson

apps/elixir_ls_debugger/lib/debugger/cli.ex

@@ -3,6 +3,7 @@ defmodule ElixirLS.Debugger.CLI do
   alias ElixirLS.Debugger.{Output, Server}
 
   def main do
+    Application.put_env(:elixir, :ansi_enabled, false)
     WireProtocol.intercept_output(&Output.debuggee_out/1, &Output.debuggee_err/1)
     Launch.start_mix()
     {:ok, _} = Application.ensure_all_started(:elixir_ls_debugger, :permanent)

apps/elixir_ls_debugger/lib/debugger/server.ex

@@ -963,6 +963,9 @@ defmodule ElixirLS.Debugger.Server do
 
     Mix.Task.run("loadconfig")
 
+    # make sure ANSI is disabled
+    Application.put_env(:elixir, :ansi_enabled, false)
+
     unless is_list(task_args) and "--no-compile" in task_args do
       case Mix.Task.run("compile", ["--ignore-module-conflict"]) do
         {:error, _} ->

apps/language_server/lib/language_server/build.ex

@@ -152,7 +152,22 @@ defmodule ElixirLS.LanguageServer.Build do
         # The project may override our logger config, so we reset it after loading their config
         logger_config = Application.get_all_env(:logger)
         Mix.Task.run("loadconfig")
-        Application.put_all_env([logger: logger_config], persistent: true)
+        Application.put_all_env([logger: logger_config])
+
+        # make sure ANSI is disabled
+        Application.put_env(:elixir, :ansi_enabled, false)
+
+        if Version.match?(System.version(), ">= 1.15.0-dev") do
+          # remove log handlers
+          handler_ids = :logger.get_handler_ids()
+          for handler_id <- handler_ids, handler != Logger.Backends.JsonRpc do
+            :ok = :logger.remove_handler(handler_id) do
+          end
+          # make sure our handler is installed
+          if Logger.Backends.JsonRpc not in handler_ids do
+            :ok = :logger.add_handler(Logger.Backends.JsonRpc, Logger.Backends.JsonRpc, Logger.Backends.JsonRpc.handler_config())
+          end
+        end
       end
 
       {status, diagnostics}

apps/language_server/lib/language_server/cli.ex

@@ -5,13 +5,14 @@ defmodule ElixirLS.LanguageServer.CLI do
   require Logger
 
   def main do
+    Application.put_env(:elixir, :ansi_enabled, false)
     WireProtocol.intercept_output(&JsonRpc.print/1, &JsonRpc.print_err/1)
 
     # :logger application is already started
     # replace console logger with LSP
     if Version.match?(System.version(), ">= 1.15.0-dev") do
       :ok = :logger.remove_handler(:default)
-      :ok = :logger.add_handler(Logger.Backends.JsonRpc, Logger.Backends.JsonRpc, %{formatter: Logger.default_formatter(colors: [enabled: false], format: "$message\n")})
+      :ok = :logger.add_handler(Logger.Backends.JsonRpc, Logger.Backends.JsonRpc, Logger.Backends.JsonRpc.handler_config())
     else
       Application.put_env(:logger, :backends, [Logger.Backends.JsonRpc])
 

apps/language_server/lib/language_server/json_rpc_logger_backend.ex

@@ -179,4 +179,8 @@ defmodule Logger.Backends.JsonRpc do
     chardata = formatter_mod.format(event, formatter_config)
     ElixirLS.LanguageServer.JsonRpc.log_message(elixir_log_level_to_lsp(level), chardata)
   end
+
+  def handler_config() do
+    %{formatter: Logger.default_formatter(colors: [enabled: false], format: "$message\n")}
+  end
 end