remove pre 1.13 code

Author: lukaszsamson

apps/elixir_ls_debugger/lib/debugger/server.ex

@@ -940,9 +940,6 @@ defmodule ElixirLS.Debugger.Server do
     # we assume that mix is already started and has archives and tasks loaded
     Launch.reload_mix_env_and_target()
 
-    # TODO I'm not sure why setting prune_code_paths works only here (and in client project)
-    # it does not work in mixfile
-    # but at this point we are probably modifying elixir_ls_debugger project
     Mix.ProjectStack.post_config(build_path: ".elixir_ls/debugger/build")
 
     Mix.ProjectStack.post_config(

apps/elixir_ls_utils/lib/minimum_version.ex

@@ -11,19 +11,11 @@ defmodule ElixirLS.Utils.MinimumVersion do
   end
 
   def check_elixir_version do
-    if Version.match?(System.version(), ">= 1.12.0") do
-      otp_release = String.to_integer(System.otp_release())
-
-      if Version.match?(System.version(), "< 1.13.0") and otp_release == 24 do
-        # see https://github.com/elixir-lang/elixir/pull/11158#issuecomment-981583298
-        {:error,
-         "Elixir 1.12 is not supported on OTP 24. (Currently running v#{System.version()} on OTP #{otp_release})"}
-      else
-        :ok
-      end
+    if Version.match?(System.version(), ">= 1.13.0") do
+      :ok
     else
       {:error,
-       "Elixir versions below 1.12.0 are not supported. (Currently running v#{System.version()})"}
+       "Elixir versions below 1.13.0 are not supported. (Currently running v#{System.version()})"}
     end
   end
 end

apps/language_server/lib/language_server/experimental/code_mod/format.ex

@@ -52,26 +52,15 @@ defmodule ElixirLS.LanguageServer.Experimental.CodeMod.Format do
     try do
       true = Code.ensure_loaded?(Mix.Tasks.Format)
 
-      if project_dir && Version.match?(System.version(), ">= 1.15.0-dev") do
-        {formatter_function, options} =
+      {formatter_function, options} =
+        if project_dir && Version.match?(System.version(), ">= 1.15.0-dev") do
           Mix.Tasks.Format.formatter_for_file(path, root: project_dir)
-
-        wrapped_formatter_function = wrap_with_try_catch(formatter_function)
-
-        {:ok, wrapped_formatter_function, options}
-      else
-        if Version.match?(System.version(), ">= 1.13.0") do
-          {formatter_function, options} = Mix.Tasks.Format.formatter_for_file(path)
-
-          wrapped_formatter_function = wrap_with_try_catch(formatter_function)
-
-          {:ok, wrapped_formatter_function, options}
         else
-          options = Mix.Tasks.Format.formatter_opts_for_file(path)
-          formatter = build_formatter(options)
-          {:ok, formatter, Mix.Tasks.Format.formatter_opts_for_file(path)}
+          Mix.Tasks.Format.formatter_for_file(path)
         end
-      end
+
+      wrapped_formatter_function = wrap_with_try_catch(formatter_function)
+      {:ok, wrapped_formatter_function, options}
     rescue
       e ->
         message = Exception.message(e)

apps/language_server/lib/language_server/mix_shell.ex

@@ -55,12 +55,7 @@ defmodule ElixirLS.LanguageServer.MixShell do
           true
       end
     else
-      # TODO convert to to normal call when we require elixir 1.13
-      if Version.match?(System.version(), "< 1.13.0") do
-        apply(Mix.Shell.IO, :yes?, [message])
-      else
-        apply(Mix.Shell.IO, :yes?, [message, options])
-      end
+      Mix.Shell.IO.yes(message, options)
     end
   end
 end

apps/language_server/lib/language_server/providers/execute_command/get_ex_unit_tests_in_file.ex

@@ -4,15 +4,11 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.GetExUnitTestsInFile
 
   @impl ElixirLS.LanguageServer.Providers.ExecuteCommand
   def execute([uri], _state) do
-    if Version.match?(System.version(), ">= 1.13.0") do
-      path = SourceFile.Path.from_uri(uri)
+    path = SourceFile.Path.from_uri(uri)
 
-      case ExUnitTestTracer.get_tests(path) do
-        {:ok, tests} -> {:ok, tests}
-        {:error, reason} -> {:error, :server_error, inspect(reason)}
-      end
-    else
-      {:error, :server_error, "This feature requires elixir >= 1.13"}
+    case ExUnitTestTracer.get_tests(path) do
+      {:ok, tests} -> {:ok, tests}
+      {:error, reason} -> {:error, :server_error, inspect(reason)}
     end
   end
 end

apps/language_server/lib/language_server/providers/execute_command/manipulate_pipes/ast.ex

@@ -72,43 +72,7 @@ defmodule ElixirLS.LanguageServer.Providers.ExecuteCommand.ManipulatePipes.AST d
   end
 
   def ast_to_string(ast) do
-    Macro.to_string(ast, fn node, rendered ->
-      case sigil_call(node, fn _a, s -> s end) do
-        {:ok, parsed_sigil} -> parsed_sigil
-        _ -> rendered
-      end
-    end)
-  end
-
-  # TODO: remove this when only Elixir >= 1.13 is supported
-  # The code below is copied from the Elixir source-code because a
-  # fix which was introduced in
-  # https://github.com/elixir-lang/elixir/commit/88d82f059756ed1eb56a562fae7092f77d941de8
-  # is needed for proper treatment of sigils in our use-case.
-  defp sigil_call({sigil, meta, [{:<<>>, _, _} = parts, args]} = ast, fun)
-       when is_atom(sigil) and is_list(args) do
-    delimiter = Keyword.get(meta, :delimiter, "\"")
-    {left, right} = delimiter_pair(delimiter)
-
-    case Atom.to_string(sigil) do
-      <<"sigil_", name>> when name >= ?A and name <= ?Z ->
-        args = sigil_args(args, fun)
-        {:<<>>, _, [binary]} = parts
-        formatted = <<?~, name, left::binary, binary::binary, right::binary, args::binary>>
-        {:ok, fun.(ast, formatted)}
-
-      <<"sigil_", name>> when name >= ?a and name <= ?z ->
-        args = sigil_args(args, fun)
-        formatted = "~" <> <<name>> <> interpolate(parts, left, right) <> args
-        {:ok, fun.(ast, formatted)}
-
-      _ ->
-        :error
-    end
-  end
-
-  defp sigil_call(_other, _fun) do
-    :error
+    Macro.to_string(ast)
   end
 
   defp delimiter_pair("["), do: {"[", "]"}

apps/language_server/lib/language_server/providers/folding_range/token.ex

@@ -33,10 +33,7 @@ defmodule ElixirLS.LanguageServer.Providers.FoldingRange.Token do
           {:sigil, {b1, b2, b3}, _, _, _, _, delimiter} ->
             {:sigil, {b1 - 1, b2 - 1, b3}, delimiter}
 
-          # Older versions of Tokenizer.tokenize/1
-          # TODO check which version
-          {:sigil, {b1, b2, b3}, _, _, _, delimiter} ->
-            {:sigil, {b1 - 1, b2 - 1, b3}, delimiter}
+          # TODO check multichar sigils
 
           {:bin_heredoc, {b1, b2, b3}, _, _} ->
             {:bin_heredoc, {b1 - 1, b2 - 1, b3}, nil}

apps/language_server/lib/language_server/source_file.ex

@@ -240,13 +240,9 @@ defmodule ElixirLS.LanguageServer.SourceFile do
       true = Code.ensure_loaded?(Mix.Tasks.Format)
 
       if project_dir && Version.match?(System.version(), ">= 1.15.0-dev") do
-        {:ok, apply(Mix.Tasks.Format, :formatter_for_file, [path, [root: project_dir]])}
+        {:ok, Mix.Tasks.Format.formatter_for_file(path, root: project_dir)}
       else
-        if Version.match?(System.version(), ">= 1.13.0") do
-          {:ok, apply(Mix.Tasks.Format, :formatter_for_file, [path])}
-        else
-          {:ok, {nil, apply(Mix.Tasks.Format, :formatter_opts_for_file, [path])}}
-        end
+        {:ok, Mix.Tasks.Format.formatter_for_file(path)}
       end
     rescue
       e ->

apps/language_server/lib/language_server/tracer.ex

@@ -230,12 +230,8 @@ defmodule ElixirLS.LanguageServer.Tracer do
       end
 
     attributes =
-      if Version.match?(System.version(), ">= 1.13.0") do
-        for name <- apply(Module, :attributes_in, [module]) do
-          {name, Module.get_attribute(module, name)}
-        end
-      else
-        []
+      for name <- apply(Module, :attributes_in, [module]) do
+        {name, Module.get_attribute(module, name)}
       end
 
     %{
@@ -282,7 +278,7 @@ defmodule ElixirLS.LanguageServer.Tracer do
   end
 
   def get_trace do
-    # TODO get by calee
+    # TODO get by callee
     :ets.tab2list(table_name(:calls))
     |> Enum.map(fn {{callee, file, line, column}, _} ->
       %{