Skip to content

Commit b6b3b24

Browse files
committed
Stop converting strings to_charlist
1 parent 6095477 commit b6b3b24

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

lib/exqlite/sqlite3.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ defmodule Exqlite.Sqlite3 do
163163
"""
164164
@spec shrink_memory(db()) :: :ok | {:error, reason()}
165165
def shrink_memory(conn) do
166-
Sqlite3NIF.execute(conn, String.to_charlist("PRAGMA shrink_memory"))
166+
Sqlite3NIF.execute(conn, "PRAGMA shrink_memory")
167167
end
168168

169169
@spec fetch_all(db(), statement(), integer()) :: {:ok, [row()]} | {:error, reason()}
@@ -198,7 +198,7 @@ defmodule Exqlite.Sqlite3 do
198198
"""
199199
@spec serialize(db(), String.t()) :: {:ok, binary()} | {:error, reason()}
200200
def serialize(conn, database \\ "main") do
201-
Sqlite3NIF.serialize(conn, String.to_charlist(database))
201+
Sqlite3NIF.serialize(conn, database)
202202
end
203203

204204
@doc """
@@ -207,7 +207,7 @@ defmodule Exqlite.Sqlite3 do
207207
"""
208208
@spec deserialize(db(), String.t(), binary()) :: :ok | {:error, reason()}
209209
def deserialize(conn, database \\ "main", serialized) do
210-
Sqlite3NIF.deserialize(conn, String.to_charlist(database), serialized)
210+
Sqlite3NIF.deserialize(conn, database, serialized)
211211
end
212212

213213
def release(_conn, nil), do: :ok

lib/exqlite/sqlite3_nif.ex

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ defmodule Exqlite.Sqlite3NIF do
1717
:erlang.load_nif(path, 0)
1818
end
1919

20-
@spec open(String.Chars.t(), integer()) :: {:ok, db()} | {:error, reason()}
20+
@spec open(String.t() | String.Chars.t(), integer()) :: {:ok, db()} | {:error, reason()}
2121
def open(_path, _flags), do: :erlang.nif_error(:not_loaded)
2222

2323
@spec close(db()) :: :ok | {:error, reason()}
@@ -26,13 +26,13 @@ defmodule Exqlite.Sqlite3NIF do
2626
@spec interrupt(db()) :: :ok | {:error, reason()}
2727
def interrupt(_conn), do: :erlang.nif_error(:not_loaded)
2828

29-
@spec execute(db(), String.Chars.t()) :: :ok | {:error, reason()}
29+
@spec execute(db(), String.t() | String.Chars.t()) :: :ok | {:error, reason()}
3030
def execute(_conn, _sql), do: :erlang.nif_error(:not_loaded)
3131

3232
@spec changes(db()) :: {:ok, integer()} | {:error, reason()}
3333
def changes(_conn), do: :erlang.nif_error(:not_loaded)
3434

35-
@spec prepare(db(), String.Chars.t()) :: {:ok, statement()} | {:error, reason()}
35+
@spec prepare(db(), String.t() | String.Chars.t()) :: {:ok, statement()} | {:error, reason()}
3636
def prepare(_conn, _sql), do: :erlang.nif_error(:not_loaded)
3737

3838
@spec bind(db(), statement(), list()) ::
@@ -55,10 +55,10 @@ defmodule Exqlite.Sqlite3NIF do
5555
@spec transaction_status(db()) :: {:ok, :idle | :transaction}
5656
def transaction_status(_conn), do: :erlang.nif_error(:not_loaded)
5757

58-
@spec serialize(db(), String.Chars.t()) :: {:ok, binary()} | {:error, reason()}
58+
@spec serialize(db(), String.t() | String.Chars.t()) :: {:ok, binary()} | {:error, reason()}
5959
def serialize(_conn, _database), do: :erlang.nif_error(:not_loaded)
6060

61-
@spec deserialize(db(), String.Chars.t(), binary()) :: :ok | {:error, reason()}
61+
@spec deserialize(db(), String.t() | String.Chars.t(), binary()) :: :ok | {:error, reason()}
6262
def deserialize(_conn, _database, _serialized), do: :erlang.nif_error(:not_loaded)
6363

6464
@spec release(db(), statement()) :: :ok | {:error, reason()}

0 commit comments

Comments
 (0)