Don't translate string to charlist before sending to NIF (#179)

Author: warmwaffles

c_src/sqlite3_nif.c

@@ -204,10 +204,6 @@ exqlite_execute(ErlNifEnv* env, int argc, const ERL_NIF_TERM argv[])
         return make_error_tuple(env, "sql_not_iolist");
     }
 
-    enif_inspect_iolist_as_binary(env,
-                                  enif_make_list2(env, argv[1], eos),
-                                  &bin);
-
     rc = sqlite3_exec(conn->db, (char*)bin.data, NULL, NULL, NULL);
     if (rc != SQLITE_OK) {
         return make_sqlite3_error_tuple(env, rc, conn->db);

lib/exqlite/sqlite3.ex

@@ -43,7 +43,7 @@ defmodule Exqlite.Sqlite3 do
   """
   @spec execute(db(), String.t()) :: :ok | {:error, reason()}
   def execute(conn, sql) do
-    case Sqlite3NIF.execute(conn, String.to_charlist(sql)) do
+    case Sqlite3NIF.execute(conn, sql) do
       :ok -> :ok
       {:error, reason} -> {:error, reason}
       _ -> {:error, "unhandled error"}

test/exqlite/sqlite3_test.exs

@@ -87,6 +87,18 @@ defmodule Exqlite.Sqlite3Test do
       :ok =
         Sqlite3.execute(conn, "insert into things(content) VALUES ('this is content')")
     end
+
+    test "handles unicode characters" do
+      {:ok, conn} = Sqlite3.open(":memory:")
+
+      :ok =
+        Exqlite.Sqlite3.execute(
+          conn,
+          "create table test (id integer primary key, stuff text)"
+        )
+
+      :ok = Exqlite.Sqlite3.execute(conn, "insert into test (stuff) values ('😝')")
+    end
   end
 
   describe ".prepare/3" do