Skip to content

Add candidate pairs stats #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2025
Merged

Add candidate pairs stats #203

merged 2 commits into from
Mar 6, 2025

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Mar 4, 2025

This PR adds candidate pairs stats to the stats report. Not all fields from the W3C spec are available yet. They will be added when needed. This PR includes stats especially helpful in debugging ICE connectivity issues i.e. STUN binding requests/responses received/sent.

Relevant specs:

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.42%. Comparing base (241931e) to head (e9ee2df).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/dtls_transport.ex 40.00% 3 Missing ⚠️
lib/ex_webrtc/peer_connection.ex 85.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
+ Coverage   88.38%   88.42%   +0.04%     
==========================================
  Files          49       49              
  Lines        2531     2549      +18     
==========================================
+ Hits         2237     2254      +17     
- Misses        294      295       +1     
Files with missing lines Coverage Δ
lib/ex_webrtc/dtls_transport.ex 83.45% <40.00%> (-1.95%) ⬇️
lib/ex_webrtc/peer_connection.ex 86.71% <85.00%> (+0.44%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241931e...e9ee2df. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mickel8 mickel8 marked this pull request as ready for review March 4, 2025 18:08
@mickel8 mickel8 requested review from brzep and sgfn March 4, 2025 18:12
Base automatically changed from self-crash to master March 6, 2025 09:51
@mickel8 mickel8 merged commit 75a378c into master Mar 6, 2025
3 checks passed
@mickel8 mickel8 deleted the stats branch March 6, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant