Skip to content

Allow passing names of default codecs #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

sgfn
Copy link
Member

@sgfn sgfn commented Mar 7, 2025

No description provided.

@sgfn sgfn requested a review from mickel8 March 7, 2025 18:39
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.29%. Comparing base (880099e) to head (dcdc052).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/peer_connection/configuration.ex 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   88.30%   88.29%   -0.01%     
==========================================
  Files          49       49              
  Lines        2549     2564      +15     
==========================================
+ Hits         2251     2264      +13     
- Misses        298      300       +2     
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection/configuration.ex 95.05% <86.66%> (-0.76%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880099e...dcdc052. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mickel8 mickel8 merged commit 26f929d into master Mar 13, 2025
3 checks passed
@mickel8 mickel8 deleted the sgfn/default-codec-shorthands branch March 13, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants