Skip to content

Commit 7cdc8a1

Browse files
committed
docs: switch to new module imports in rule examples
1 parent 4e80839 commit 7cdc8a1

8 files changed

+47
-25
lines changed

docs/rules/computed-property-getters.md

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,10 @@ String option:
2020
### always-with-setter
2121

2222
```javascript
23+
import EmberObject, { computed } from '@ember/object';
24+
2325
// BAD
24-
Ember.Object.extend({
26+
EmberObject.extend({
2527
fullName: computed('firstName', 'lastName', {
2628
get() {
2729
// ...
@@ -30,14 +32,14 @@ Ember.Object.extend({
3032
});
3133

3234
// GOOD
33-
Ember.Object.extend({
35+
EmberObject.extend({
3436
fullName: computed('firstName', 'lastName', function () {
3537
// ...
3638
})
3739
});
3840

3941
// GOOD
40-
Ember.Object.extend({
42+
EmberObject.extend({
4143
fullName: computed('firstName', 'lastName', {
4244
set() {
4345
// ...
@@ -52,8 +54,10 @@ Ember.Object.extend({
5254
### always
5355

5456
```javascript
57+
import EmberObject, { computed } from '@ember/object';
58+
5559
// GOOD
56-
Ember.Object.extend({
60+
EmberObject.extend({
5761
fullName: computed('firstName', 'lastName', {
5862
get() {
5963
// ...
@@ -62,7 +66,7 @@ Ember.Object.extend({
6266
});
6367

6468
// BAD
65-
Ember.Object.extend({
69+
EmberObject.extend({
6670
fullName: computed('firstName', 'lastName', function () {
6771
// ...
6872
})
@@ -72,15 +76,17 @@ Ember.Object.extend({
7276
### never
7377

7478
```javascript
79+
import EmberObject, { computed } from '@ember/object';
80+
7581
// GOOD
76-
Ember.Object.extend({
82+
EmberObject.extend({
7783
fullName: computed('firstName', 'lastName', function () {
7884
// ...
7985
})
8086
});
8187

8288
// BAD
83-
Ember.Object.extend({
89+
EmberObject.extend({
8490
fullName: computed('firstName', 'lastName', {
8591
get() {
8692
// ...
@@ -89,7 +95,7 @@ Ember.Object.extend({
8995
});
9096

9197
// BAD
92-
Ember.Object.extend({
98+
EmberObject.extend({
9399
fullName: computed('firstName', 'lastName', {
94100
get() {
95101
// ...

docs/rules/jquery-ember-run.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,16 +9,21 @@ Using plain jQuery invokes actions out of the Ember Run Loop. In order to have a
99
Examples of **incorrect** code for this rule:
1010

1111
```js
12-
Ember.$('#something-rendered-by-jquery-plugin').on('click', () => {
12+
import $ from 'jquery';
13+
14+
$('#something-rendered-by-jquery-plugin').on('click', () => {
1315
this._handlerActionFromController();
1416
});
1517
```
1618

1719
Examples of **correct** code for this rule:
1820

1921
```javascript
20-
Ember.$('#something-rendered-by-jquery-plugin').on(
22+
import $ from 'jquery';
23+
import { bind } from '@ember/runloop';
24+
25+
$('#something-rendered-by-jquery-plugin').on(
2126
'click',
22-
Ember.run.bind(this, this._handlerActionFromController)
27+
bind(this, this._handlerActionFromController)
2328
);
2429
```

docs/rules/no-attrs-snapshot.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,9 @@ If for some reason you need to do a comparison of arguments we suggest that you
1515
Examples of **incorrect** code for this rule:
1616

1717
```js
18+
import Component from '@ember/component';
1819

19-
export default Ember.Component({
20+
export default Component({
2021
init(...args) {
2122
this._super(...args);
2223
this.updated = false;
@@ -36,8 +37,9 @@ export default Ember.Component({
3637
Examples of **correct** code for this rule:
3738

3839
```js
40+
import Component from '@ember/component';
3941

40-
export default Ember.Component({
42+
export default Component({
4143
init(...args) {
4244
this._super(...args);
4345
this._valueCache = this.value;

docs/rules/no-computed-properties-in-native-classes.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ This rule disallows using computed properties with native classes.
1111
Examples of **incorrect** code for this rule:
1212

1313
```js
14+
import Component from '@ember/component';
1415
import { and, or, alias } from '@ember/object/computed';
1516

1617
export default class MyComponent extends Component {
@@ -19,6 +20,7 @@ export default class MyComponent extends Component {
1920
```
2021

2122
```js
23+
import Component from '@ember/component';
2224
import { computed } from '@ember/object';
2325

2426
export default class MyComponent extends Component {
@@ -32,14 +34,14 @@ Examples of **correct** code for this rule:
3234
import { computed } from '@ember/object';
3335
import Component from '@ember/component';
3436

35-
export default Ember.Component.extend({});
37+
export default Component.extend({});
3638
```
3739

3840
```js
3941
import { alias, or, and } from '@ember/object/computed';
4042
import Component from '@ember/component';
4143

42-
export default Ember.Component.extend({});
44+
export default Component.extend({});
4345
```
4446

4547
```js

docs/rules/no-ember-testing-in-module-scope.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ of destructuring.
1414
Examples of **incorrect** code for this rule:
1515

1616
```js
17+
import Component from '@ember/component';
18+
1719
export default Component.extend({
1820
init() {
1921
this.isTesting = Ember.testing;
@@ -23,8 +25,9 @@ export default Component.extend({
2325

2426
```js
2527
import Ember from 'ember';
28+
import Component from '@ember/component';
2629

27-
export default Ember.Component.extend({
30+
export default Component.extend({
2831
isTesting: Ember.testing
2932
});
3033
```
@@ -45,6 +48,7 @@ Examples of **correct** code for this rule:
4548

4649
```javascript
4750
import Ember from 'ember';
51+
import Component from '@ember/component';
4852

4953
export default Component.extend({
5054
someMethod() {
@@ -59,6 +63,7 @@ export default Component.extend({
5963

6064
```js
6165
import Ember from 'ember';
66+
import Service from '@ember/service';
6267

6368
export default Service.extend({
6469
foo() {

docs/rules/no-observers.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,10 @@ Observers do have some limited uses. They let you reflect state from your applic
1818
Examples of **incorrect** code for this rule:
1919

2020
```js
21+
import { observer } from '@ember/object';
22+
2123
export default Controller.extend({
22-
change: Ember.observer('text', function () {
24+
change: observer('text', function () {
2325
console.log(`change detected: ${this.text}`);
2426
})
2527
});

docs/rules/no-side-effects.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,8 @@ When using computed properties do not introduce side effects. It will make reaso
77
## Examples
88

99
```javascript
10-
import Ember from 'ember';
11-
12-
const {
13-
Component,
14-
computed: { filterBy, alias }
15-
} = Ember;
10+
import Component from '@ember/component';
11+
import { alias, filterBy } from '@ember/object/computed';
1612

1713
export default Component.extend({
1814
init(...args) {

docs/rules/require-super-in-init.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,9 @@ When overriding the `init` lifecycle hook inside Ember Components, Controllers,
99
Examples of **incorrect** code for this rule:
1010

1111
```javascript
12-
export default Ember.Component.extend({
12+
import Component from '@ember/component';
13+
14+
export default Component.extend({
1315
init() {
1416
this.set('items', []);
1517
}
@@ -19,7 +21,9 @@ export default Ember.Component.extend({
1921
Examples of **correct** code for this rule:
2022

2123
```javascript
22-
export default Ember.Component.extend({
24+
import Component from '@ember/component';
25+
26+
export default Component.extend({
2327
init(...args) {
2428
this._super(...args);
2529
this.set('items', []);

0 commit comments

Comments
 (0)