Skip to content

Commit 38c48dc

Browse files
committed
Avoid reduce error in test
1 parent 04992bd commit 38c48dc

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

app/services/meta-store.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import Service from '@ember/service';
22
import { isPresent } from '@ember/utils';
3+
import { get, set } from '@ember/object';
34
import { A } from '@ember/array';
45
import getCompactVersion from 'ember-api-docs/utils/get-compact-version';
56

@@ -18,10 +19,10 @@ export default Service.extend({
1819
},
1920

2021
addToProjectRevMap(projectVersionKey, projectRevDoc) {
21-
let projectRevMap = this.get('projectRevMap');
22+
let projectRevMap = get(this, 'projectRevMap');
2223
if (!isPresent(projectRevMap[projectVersionKey])) {
2324
projectRevMap[projectVersionKey] = projectRevDoc;
24-
this.set('projectRevMap', projectRevMap);
25+
set(this, 'projectRevMap', projectRevMap);
2526
}
2627
},
2728

@@ -47,6 +48,9 @@ export default Service.extend({
4748
getFullVersion(projectName, compactProjVersion) {
4849
const availProjVersions = this.get(`availableProjectVersions.${projectName}`);
4950
let filtered = availProjVersions.filter((v) => getCompactVersion(v) === getCompactVersion(compactProjVersion));
51+
if (filtered.length === 0) {
52+
return;
53+
}
5054
// since there can be multiple full versions that match the compact version, use the most recent one.
5155
return filtered.reduce((accumulator, current) => accumulator.split('.')[2] < current.split('.')[2] ? current : accumulator);
5256
}

0 commit comments

Comments
 (0)