Skip to content

Commit 3e8e81f

Browse files
committed
mobile friendly header, footer, and code blocks (#317)
1 parent 61339a8 commit 3e8e81f

File tree

7 files changed

+20
-16
lines changed

7 files changed

+20
-16
lines changed

app/styles/components/_article.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ article {
9393
@media (max-width: $medium-screen) {
9494
table {
9595
td,th {
96-
display: block;
9796
border: 0;
9897
}
9998

app/styles/components/_footer.scss

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
}
1616

1717
@media screen and (max-width: 53.75rem) {
18-
.responsive .footer .container {
18+
.responsive.footer .container {
1919
padding: 2rem 1rem;
2020

2121
.footer-info {
@@ -60,8 +60,8 @@
6060
display: flex
6161
}
6262

63-
@media screen and (max-width: 53.75rem) {
64-
.responsive .footer .container {
63+
@media screen and (max-width: 40rem) {
64+
.responsive.footer .container {
6565
text-align: center;
6666
display: block;
6767
}
@@ -83,15 +83,15 @@
8383
}
8484

8585
@media screen and (max-width: 53.75rem) {
86-
.responsive .footer .footer-info {
86+
.responsive.footer .footer-info {
8787
text-align: center;
8888
}
8989

90-
.responsive .footer .footer-statement {
90+
.responsive.footer .footer-statement {
9191
text-align: center;
9292
}
9393

94-
.responsive .footer .footer-tagline {
94+
.responsive.footer .footer-tagline {
9595
padding-left: 2em;
9696
padding-right: 2em;
9797
}

app/styles/components/_header.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,8 @@ $white: white;
4343
display: -webkit-flex;
4444
}
4545

46-
@media screen and (max-width: 53.75rem) {
47-
.responsive .header .container {
46+
@media screen and (max-width: $medium-screen) {
47+
.responsive.header .container {
4848
display: block;
4949
}
5050
}
@@ -56,7 +56,7 @@ $white: white;
5656
height: 2.8rem;
5757
}
5858
@media screen and (max-width: 53.75rem) {
59-
.responsive .header .header-nav {
59+
.responsive.header .header-nav {
6060
height: auto;
6161
}
6262
}
@@ -70,7 +70,7 @@ $white: white;
7070
}
7171

7272
@media screen and (max-width: 53.75rem) {
73-
.responsive .header a {
73+
.responsive.header a {
7474
line-height: 24px; //do we need this
7575
}
7676
}

app/styles/components/_highlight.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
margin: 0;
4343
table-layout: auto;
4444
width: 100%;
45+
z-index: auto;
4546

4647
tr,
4748
th,

app/styles/components/_sidebar.scss

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,11 @@
55
z-index: 1;
66
padding: $small-spacing 0;
77

8-
@include media($medium-large-screen-up) {
8+
@include media($medium-screen-up) {
9+
margin-top: 5em;
10+
}
11+
12+
@include media($large-screen-up) {
913
// fixed sidebar, full height
1014
@include span-columns(3.5);
1115
margin-right: 0;

app/templates/application.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<header class="header">
1+
<header class="header responsive">
22
<nav role="navigation" aria-label="main">
33
<ul class="header-nav container">
44
<li class="header-logo">
@@ -20,4 +20,4 @@
2020
<main class="container">
2121
{{outlet}}
2222
</main>
23-
{{main-footer}}
23+
{{main-footer}}

app/templates/components/main-footer.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<div class="footer">
1+
<div class="footer responsive">
22
<div class="container">
33
<div class="footer-info">
44
Copyright {{currentYear}}
@@ -42,4 +42,4 @@
4242
</div>
4343

4444
</div>
45-
</div>
45+
</div>

0 commit comments

Comments
 (0)