🔥 removing jQuery usage from scroll-position-reset service

dbendaou · dbendaou · commit 40c526738203 · 2019-04-26T15:39:40.000+02:00
diff --git a/app/services/scroll-position-reset.js b/app/services/scroll-position-reset.js
@@ -1,5 +1,4 @@
 import Service from '@ember/service';
-import $ from 'jquery';
 import config from 'ember-api-docs/config/environment';
 
 const { scrollContainerSelector } = config.APP;
@@ -27,7 +26,8 @@ export default Service.extend({
 
   doReset() {
     if (this._shouldResetScroll) {
-      $(scrollContainerSelector).scrollTop(0);
+      const selector = document.querySelector(scrollContainerSelector);
+      selector.scrollTo(0,0);
       this.set('_shouldResetScroll', false);
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import Service from '@ember/service';`
`2`		`-import $ from 'jquery';`
`3`	`2`	`import config from 'ember-api-docs/config/environment';`
`4`	`3`
`5`	`4`	`const { scrollContainerSelector } = config.APP;`
`@@ -27,7 +26,8 @@ export default Service.extend({`
`27`	`26`
`28`	`27`	`doReset() {`
`29`	`28`	`if (this._shouldResetScroll) {`
`30`		`- $(scrollContainerSelector).scrollTop(0);`
	`29`	`+ const selector = document.querySelector(scrollContainerSelector);`
	`30`	`+ selector.scrollTo(0,0);`
`31`	`31`	`this.set('_shouldResetScroll', false);`
`32`	`32`	`}`
`33`	`33`	`}`