Do not include header height while calculating scroll offset

Author: akash-dsouza-3362

app/components/ember-anchor.js

@@ -10,10 +10,9 @@ export default AnchorComponent.extend({
     let qp = this.get('anchorQueryParam');
     let qpVal = this.get(get(this, 'attrs.a') ? 'a' : `controller.${qp}`);
     let elem = $(`[data-${qp}="${qpVal}"]`);
-    let offset = (elem && elem.offset && elem.offset()) ? elem.offset().top : null;
+    let offset = elem.offset() ? elem.offset().top : 0;
     if (offset) {
-      const navMenuHeight = $('header').outerHeight();
-      $(config.APP.scrollContainerSelector).scrollTop(offset - navMenuHeight - 10);
+      $(config.APP.scrollContainerSelector).scrollTop(offset);
     }
   }
 });

app/mixins/scroll-tracker.js

@@ -14,17 +14,15 @@ export default Mixin.create({
 
     didTransition() {
       this._super();
-      let isAnchorEmpty = window && window.location && window.location.search === '?anchor='
-      if ((typeof FastBoot === 'undefined') && isAnchorEmpty ) {
+      if ((typeof FastBoot === 'undefined') && window.location.search === '?anchor=' ) {
         let elem = $('#methods');
-        let offset = (elem && elem.offset && elem.offset()) ? elem.offset().top : null;
+        let offset = elem.offset() ? elem.offset().top : 0;
         if (offset) {
-          const navMenuHeight = $('header').outerHeight();
-          $(config.APP.scrollContainerSelector).scrollTop(offset - navMenuHeight - 10);
+          $(config.APP.scrollContainerSelector).scrollTop(offset - 10);
+          return;
         }
-      } else {
-        this.get('scrollPositionReset').doReset();
       }
+      this.get('scrollPositionReset').doReset();
     }
   }
 });