Skip to content

Commit 4939a82

Browse files
authored
Merge pull request #783 from rajakvk/rk-775-fix-linting-error-7
Fix linting errors #775
2 parents e26c8df + 44cf363 commit 4939a82

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

app/controllers/project-version.js

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/* eslint-disable ember/no-computed-properties-in-native-classes, ember/classic-decorator-no-classic-methods */
1+
/* eslint-disable ember/no-computed-properties-in-native-classes */
22
import { computed } from '@ember/object';
33
import { inject as service } from '@ember/service';
44
import { readOnly, alias } from '@ember/object/computed';
@@ -44,12 +44,12 @@ export default class ProjectVersionController extends Controller {
4444

4545
@computed('model.id')
4646
get moduleIDs() {
47-
return this.getModuleRelationships(this.get('model.id'), 'modules');
47+
return this.getModuleRelationships(this.model.id, 'modules');
4848
}
4949

5050
@computed('model.id')
5151
get publicModuleIDs() {
52-
return this.getModuleRelationships(this.get('model.id'), 'public-modules');
52+
return this.getModuleRelationships(this.model.id, 'public-modules');
5353
}
5454

5555
getModuleRelationships(versionId, moduleType) {
@@ -65,6 +65,7 @@ export default class ProjectVersionController extends Controller {
6565
}
6666

6767
getRelationshipIDs(relationship) {
68+
// eslint-disable-next-line
6869
const splitPoint = 2 + this.get('model.project.id').split('-').length - 1;
6970
const classes = this.model.hasMany(relationship);
7071
const sorted = A(classes.ids()).sort();
@@ -94,9 +95,8 @@ export default class ProjectVersionController extends Controller {
9495

9596
@computed('metaStore.availableProjectVersions', 'model.project.id')
9697
get projectVersions() {
97-
const projectVersions = this.get('metaStore.availableProjectVersions')[
98-
this.get('model.project.id')
99-
];
98+
const projectVersions =
99+
this.metaStore.availableProjectVersions[this.model.project.get('id')];
100100
let versions = projectVersions.sort((a, b) => semverCompare(b, a));
101101

102102
versions = versions.map((version) => {
@@ -116,9 +116,7 @@ export default class ProjectVersionController extends Controller {
116116

117117
@computed('projectVersions.[]', 'model.version')
118118
get selectedProjectVersion() {
119-
return this.projectVersions.filter(
120-
(pV) => pV.id === this.get('model.version')
121-
)[0];
119+
return this.projectVersions.filter((pV) => pV.id === this.model.version)[0];
122120
}
123121

124122
@readOnly('model.project.id')

0 commit comments

Comments
 (0)