Merge pull request #942 from ember-learn/this-fallback

fix this-property-fallback deprecation

Author: mansona

app/deprecation-workflow.js

@@ -5,7 +5,7 @@ setupDeprecationWorkflow({
   workflow: [
     { handler: 'throw', matchId: 'ember.component.reopen' },
     { handler: 'throw', matchId: 'implicit-injections' },
-    { handler: 'silence', matchId: 'this-property-fallback' },
+    { handler: 'throw', matchId: 'this-property-fallback' },
     { handler: 'throw', matchId: 'ember-component.is-visible' },
     {
       handler: 'silence',

tests/integration/helpers/better-get-test.js

@@ -13,7 +13,7 @@ module('helper:better-get', function (hooks) {
     this.set('dataStructure', obj);
     this.set('key', 'Ember.Object');
 
-    await render(hbs`{{better-get dataStructure key}}`);
+    await render(hbs`{{better-get this.dataStructure this.key}}`);
 
     assert.dom(this.element).hasText('hello');
   });
@@ -25,7 +25,7 @@ module('helper:better-get', function (hooks) {
     this.set('dataStructure', obj);
     this.set('key', '@ember/object');
 
-    await render(hbs`{{better-get dataStructure key}}`);
+    await render(hbs`{{better-get this.dataStructure this.key}}`);
 
     assert.dom(this.element).hasText('hello');
   });

tests/integration/helpers/function-heading-id-test.js

@@ -9,7 +9,7 @@ module('helper:function-heading-id', function (hooks) {
   test('should transform nested package to id', async function (assert) {
     this.set('inputValue', '@ember/object/computed');
 
-    await render(hbs`{{function-heading-id inputValue}}`);
+    await render(hbs`{{function-heading-id this.inputValue}}`);
 
     assert.dom(this.element).hasText('functions-computed');
   });