Refactor some inits

Co-authored-by: Chris Manson <[email protected]>

Author: jenweber

app/services/filter-data.js

@@ -1,16 +1,14 @@
 import Service from '@ember/service';
 
 export default class FilterDataService extends Service {
+  // These attributes are not @tracked because they are used in computed
+  // properties and not directly in templates.
   showInherited = false;
   showProtected = false;
   showPrivate = false;
   showDeprecated = false;
-  sideNav = null;
 
-  init() {
-    this.sideNav = {
-      showPrivate: false,
-    };
-    super.init(...arguments);
-  }
+  sideNav = {
+    showPrivate: false,
+  };
 }

app/services/legacy-module-mappings.js

@@ -1,5 +1,6 @@
 import fetch from 'fetch';
 import Service from '@ember/service';
+import { tracked } from '@glimmer/tracking';
 
 const LOCALNAME_CONVERSIONS = {
   Object: 'EmberObject',
@@ -8,14 +9,16 @@ const LOCALNAME_CONVERSIONS = {
 };
 
 export default class LegacyModuleMappingsService extends Service {
+  @tracked mappings;
+
   async initMappings() {
     try {
       let response = await this.fetch();
       let mappings = await response.json();
       let newMappings = this.buildMappings(mappings);
-      this.set('mappings', newMappings);
+      this.mappings = newMappings;
     } catch (e) {
-      this.set('mappings', []);
+      this.mappings = [];
     }
   }
 

app/services/project.js

@@ -1,5 +1,5 @@
 import Service from '@ember/service';
-import { tracked } from '@glimmer/tracking'
+import { tracked } from '@glimmer/tracking';
 
 export default class ProjectService extends Service {
   @tracked version = '0.0.0';