Skip to content

Commit 93095cd

Browse files
Gaurav0sivakumar-kailasam
authored andcommitted
fix cannot switch to Ember 1.13
1 parent afa6439 commit 93095cd

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

app/services/meta-store.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { isPresent } from '@ember/utils';
33
import { set } from '@ember/object';
44
import { A } from '@ember/array';
55
import getCompactVersion from 'ember-api-docs/utils/get-compact-version';
6+
import getLastVersion from 'ember-api-docs/utils/get-last-version';
67

78
export default Service.extend({
89

@@ -52,6 +53,6 @@ export default Service.extend({
5253
return;
5354
}
5455
// since there can be multiple full versions that match the compact version, use the most recent one.
55-
return filtered.reduce((accumulator, current) => accumulator.split('.')[2] < current.split('.')[2] ? current : accumulator);
56+
return getLastVersion(filtered);
5657
}
5758
});

tests/acceptance/switch-versions-test.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,4 +171,16 @@ module('Acceptance | version navigation', function(hooks) {
171171
await waitForSettled();
172172
assert.equal(currentURL(), '/ember/2.18/classes/Component', 'navigated to v2.18 for new class');
173173
});
174+
175+
test(`can switch to ember 1.13`, async function(assert) {
176+
await visit('/ember/2.0/classes/Ember.Component');
177+
await waitForSettled();
178+
assert.equal(currentURL(), '/ember/2.0/classes/Ember.Component', 'navigated to v2.0 namespace');
179+
await selectChoose('.ember-power-select-trigger', '1.12');
180+
await waitForSettled();
181+
assert.equal(currentURL(), '/ember/1.12/classes/Ember.Component', 'navigated to v1.12 class');
182+
await selectChoose('.ember-power-select-trigger', '1.13');
183+
await waitForSettled();
184+
assert.equal(currentURL(), '/ember/1.13/classes/Ember.Component', 'navigated to v1.13 class');
185+
});
174186
});

0 commit comments

Comments
 (0)