Skip to content

Commit 9ac81b7

Browse files
Merge pull request #641 from Gaurav0/fix_ember_data_source_links
[BUGFIX] fix ember-data source links for v3.11+
2 parents d293129 + ec3dcb8 commit 9ac81b7

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

app/helpers/github-link.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import { helper } from '@ember/component/helper';
2-
import githubMap from '../utils/github-map';
2+
import githubMap, { mainDir } from '../utils/github-map';
33

44
export function githubLink([project, version, file, line], { isEdit=false }) {
55
if (isEdit) {
6-
return `https://github.com/${githubMap[project]}/edit/release/${file}#L${line}`;
6+
return `https://github.com/${githubMap[project]}/edit/release${mainDir(project, version)}${file}#L${line}`;
77
}
8-
return `https://github.com/${githubMap[project]}/tree/v${version}/${file}#L${line}`;
8+
return `https://github.com/${githubMap[project]}/tree/v${version}${mainDir(project, version)}${file}#L${line}`;
99
}
1010

1111
export default helper(githubLink);

app/utils/github-map.js

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
import semverCompare from 'semver-compare';
2+
3+
export const mainDir = function(project, version) {
4+
if (project === 'ember') {
5+
return '/';
6+
}
7+
if (project === 'ember-data') {
8+
if (semverCompare(version, '3.11') === -1) {
9+
return '/';
10+
}
11+
return '/packages/-ember-data/';
12+
}
13+
};
14+
115
export default {
216
'ember': 'emberjs/ember.js',
317
'ember-data': 'emberjs/data'

0 commit comments

Comments
 (0)