Skip to content

Commit a666ebc

Browse files
lifearttoddjordan
authored andcommitted
typo fixes & test for meta-store
1 parent bf4a646 commit a666ebc

File tree

2 files changed

+81
-5
lines changed

2 files changed

+81
-5
lines changed

app/routes/project-version/classes/class.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export default Route.extend(ScrollTracker, {
1515
metaStore: service(),
1616

1717
titleToken: function(model) {
18-
return model.get('name');
18+
return get(model, 'name');
1919
},
2020

2121
async model(params, transition) {
@@ -79,7 +79,7 @@ export default Route.extend(ScrollTracker, {
7979

8080
serialize(model) {
8181
return {
82-
class: model.get('name')
82+
class: get(model, 'name')
8383
};
8484
}
8585

tests/unit/services/meta-store-test.js

Lines changed: 79 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,86 @@ import { moduleFor, test } from 'ember-qunit';
22

33
moduleFor('service:meta-store', 'Unit | Service | meta-store');
44

5-
// Replace this with your real tests.
6-
test('it exists', function(assert) {
5+
const availableProjectVersions = {
6+
"ember":[
7+
"2.14.1","2.13.4","1.0.0","1.1.2","1.10.1","1.11.4",
8+
"1.12.2","1.13.13","1.2.2","1.3.2","1.4.0","1.5.1",
9+
"1.6.1","1.7.1","1.8.1","1.9.1","2.0.3","2.1.2",
10+
"2.10.2","2.14.0"
11+
],
12+
"ember-data":[]
13+
};
14+
15+
const projectRevMap = {
16+
"ember-2.14.1":{
17+
"class":{
18+
"ember-2.14.1-Transition":"ember-2.14.1-Transition-e2c9dc8c5d",
19+
"ember-2.14.1-RSVP":"ember-2.14.1-RSVP-4a03b05e6b",
20+
"ember-2.14.1-RSVP.EventTarget":"ember-2.14.1-RSVP.EventTarget-10cdced26e",
21+
"ember-2.14.1-RSVP.Promise":"ember-2.14.1-RSVP.Promise-fbbcd10984",
22+
"ember-2.14.1-Registry":"ember-2.14.1-Registry-4c1d3349b8",
23+
"ember-2.14.1-Ember.ApplicationInstance":"ember-2.14.1-Ember.ApplicationInstance-6c74055348",
24+
"ember-2.14.1-Ember.ApplicationInstance.BootOptions":"ember-2.14.1-Ember.ApplicationInstance.BootOptions-d85accfd00",
25+
"ember-2.14.1-Ember.ContainerDebugAdapter":"ember-2.14.1-Ember.ContainerDebugAdapter-a638d957ef",
26+
"ember-2.14.1-Ember.DataAdapter":"ember-2.14.1-Ember.DataAdapter-13d97fba8e",
27+
"ember-2.14.1-Ember.Checkbox":"ember-2.14.1-Ember.Checkbox-ac010b20de",
28+
"ember-2.14.1-Ember.Templates.helpers":"ember-2.14.1-Ember.Templates.helpers-8ad35165c6",
29+
"ember-2.14.1-Ember.LinkComponent":"ember-2.14.1-Ember.LinkComponent-1f73e68442"
30+
},
31+
"namespace":{
32+
"ember-2.14.1-Ember":"ember-2.14.1-Ember-ada1cbc5c0",
33+
"ember-2.14.1-Ember.FEATURES":"ember-2.14.1-Ember.FEATURES-90a821dc67",
34+
"ember-2.14.1-Ember.String":"ember-2.14.1-Ember.String-c2c5c7e7df",
35+
"ember-2.14.1-Ember.computed":"ember-2.14.1-Ember.computed-e20827f87a",
36+
"ember-2.14.1-Ember.Instrumentation":"ember-2.14.1-Ember.Instrumentation-444cd5ed44",
37+
"ember-2.14.1-Ember.run":"ember-2.14.1-Ember.run-9984e22369",
38+
"ember-2.14.1-Ember.Location":"ember-2.14.1-Ember.Location-d9c1564180",
39+
"ember-2.14.1-Ember.AutoLocation":"ember-2.14.1-Ember.AutoLocation-4b8744f1e4"
40+
},
41+
"module":{
42+
"ember-2.14.1-ember":"ember-2.14.1-ember-d11dc7bcaf",
43+
"ember-2.14.1-ember-application":"ember-2.14.1-ember-application-f34af3b30d",
44+
"ember-2.14.1-ember-extension-support":"ember-2.14.1-ember-extension-support-46321b0650"
45+
},
46+
"missing":{
47+
"EmberObject":"EmberObject-9bb68cdfb6","Error":"Error-158974c414"
48+
}
49+
}
50+
};
51+
52+
const fakeProjectRevMap = {
53+
"class": {
54+
"ember-42": "ember-42-hash"
55+
}
56+
};
57+
58+
test('it should be properly initialized', function(assert) {
59+
let service = this.subject();
60+
service.initializeStore(availableProjectVersions, projectRevMap);
61+
assert.ok(service.get('availableProjectVersions.ember.length'));
62+
});
63+
64+
test('it should return correct fullVersion from compact', function(assert) {
65+
let service = this.subject();
66+
service.initializeStore(availableProjectVersions, projectRevMap);
67+
assert.equal(service.getFullVersion('ember', '2.14'), '2.14.1');
68+
assert.equal(service.getFullVersion('ember', '2.1'), '2.14.1');
69+
assert.equal(service.getFullVersion('ember', '2.14.'), '2.14.1');
70+
assert.equal(service.getFullVersion('ember', '1.14'), undefined);
71+
});
72+
73+
74+
test('it should correct execute addToProjectRevMap', function(assert) {
75+
let service = this.subject();
76+
service.initializeStore(availableProjectVersions, projectRevMap);
77+
service.addToProjectRevMap('ember-2.14.90.12', fakeProjectRevMap);
78+
assert.equal(service.getRevId('ember', '2.14.90.12', 'class', 'ember-42'), 'ember-42-hash');
79+
});
80+
81+
test('it should return correct RevId', function(assert) {
782
let service = this.subject();
8-
assert.ok(service);
83+
service.initializeStore(availableProjectVersions, projectRevMap);
84+
assert.equal(typeof service.getRevId('ember', '2.14.1', 'namespace', 'ember-2.14.1-Ember.Instrumentation'), 'string');
985
});
1086

1187
test('correct version selected', function(assert) {

0 commit comments

Comments
 (0)