fix lint and tests

Author: Gaurav0

.eslintrc.js

@@ -23,7 +23,7 @@ module.exports = {
   rules: {
     'ember/no-jquery': 'off',
     'no-console': 'off',
-    'ember/avoid-leaking-state-in-ember-objects': 1
+    'ember/no-new-mixins': 'off'
   },
   overrides: [
     // node files

.template-lintrc.js

@@ -7,6 +7,9 @@ module.exports = {
     'attribute-indentation': false,
     'no-unnecessary-concat': false,
     'no-inline-styles': false,
+    'no-implicit-this': false,
+    'no-curly-component-invocation': false,
+    'no-action': false,
     quotes: false
   }
 };

app/router.js

@@ -10,26 +10,28 @@ class AppRouter extends Router {
   @service metrics;
   @service fastboot;
 
-  init() {
-    this._super(...arguments);
+  constructor() {
+    super(...arguments);
 
     if (!this.get('fastboot.isFastBoot')) {
-      this.on('routeDidChange', () => this._trackPage());
+      this.on('routeDidChange', this, this._trackPage);
     }
-  },
+  }
 
   _trackPage() {
-    scheduleOnce('afterRender', this, () => {
+    scheduleOnce('afterRender', this, this.__trackPage);
+  }
 
-      // this is constant for this app and is only used to identify page views in the GA dashboard
-      const hostname = config.APP.domain.replace(/(http|https)?:?\/\//g, '');
+  __trackPage() {
 
-      const page = this.url;
-      const title = this.getWithDefault('currentRouteName', 'unknown');
-      this.metrics.trackPage({ page, title, hostname });
-    });
+    // this is constant for this app and is only used to identify page views in the GA dashboard
+    const hostname = config.APP.domain.replace(/(http|https)?:?\/\//g, '');
+
+    const page = this.url;
+    const title = this.getWithDefault('currentRouteName', 'unknown');
+    this.metrics.trackPage({ page, title, hostname });
   }
-});
+}
 
 AppRouter.map(function() {
   this.route('404');

app/templates/404.hbs

@@ -4,7 +4,7 @@
   <div class="whoops__message">
     <p>
       This page wasn't found. Please try the {{#link-to 'index'}}API docs page{{/link-to}}.
-      If you expected something else to be here, please file a <a href="https://github.com/ember-learn/ember-api-docs/issues/new" target="_blank" rel="noopener">ticket</a>.
+      If you expected something else to be here, please file a <a href="https://github.com/ember-learn/ember-api-docs/issues/new" target="_blank" rel="noopener noreferrer">ticket</a>.
     </p>
   </div>
 </article>

app/templates/components/class-field-description.hbs

@@ -1,6 +1,7 @@
 <section class="{{type}}">
+  {{!-- TODO: Fix this link for a11y --}}
   <h3 class="class-field-description--link" data-anchor="{{field.name}}" role="link" onclick={{action updateAnchor field.name}}>
-    <a class="anchor">
+    <a class="anchor" {{!-- template-lint-disable link-href-attributes --}}>
       {{svg-jar 'fa-link' class="class-field-description--link-hover" width="20px" height="20px"}}
     </a>
     <span class="{{type}}-name">{{field.name}}</span>
@@ -30,12 +31,12 @@
   <p class="github-link" data-test-file={{field.file}}>
     {{#if field.inherited}}
       Inherited from
-      <a href="{{github-link model.project.id model.projectVersion.version field.file field.line}}" target="_blank" rel="noopener">
+      <a href="{{github-link model.project.id model.projectVersion.version field.file field.line}}" target="_blank" rel="noopener noreferrer">
         {{field.inheritedFrom}} {{field.file}}:{{field.line}}
       </a>
     {{else}}
       Defined in
-      <a href="{{github-link model.project.id model.projectVersion.version field.file field.line}}" target="_blank" rel="noopener">
+      <a href="{{github-link model.project.id model.projectVersion.version field.file field.line}}" target="_blank" rel="noopener noreferrer">
         {{field.file}}:{{field.line}}
       </a>
     {{/if}}

app/templates/error.hbs

@@ -4,7 +4,7 @@
     <div class="whoops__message">
       <p>
         This page wasn't found. Please try the {{#link-to 'index'}}API docs page{{/link-to}}.
-        If you expected something else to be here, please file a <a href="https://github.com/fivetanley/ember-api-docs/issues/new" target="_blank" rel="noopener">ticket</a>.
+        If you expected something else to be here, please file a <a href="https://github.com/fivetanley/ember-api-docs/issues/new" target="_blank" rel="noopener noreferrer">ticket</a>.
       </p>
     </div>
   {{else}}

app/templates/project-version/classes/class.hbs

@@ -1,6 +1,6 @@
 <article class="chapter">
   {{#if (is-latest version=model.projectVersion.version allVersions=allVersions)}}
-    <a data-tooltip="Edit on Github" class="heading__link__edit" href="{{github-link model.project.id model.projectVersion.version model.file model.line isEdit=true}}" target="_blank" rel="noopener">{{svg-jar "fa-pencil"}}</a>
+    <a data-tooltip="Edit on Github" class="heading__link__edit" href="{{github-link model.project.id model.projectVersion.version model.file model.line isEdit=true}}" target="_blank" rel="noopener noreferrer">{{svg-jar "fa-pencil"}}</a>
   {{/if}}
   <h1 class="module-name">Class {{model.name}}</h1>
   {{#if model.access}}<span class="access">{{model.access}}</span>{{/if}}
@@ -27,7 +27,7 @@
       <div class="attribute">
         <span class="attribute-label">Defined in:</span>
         <span class="attribute-value">
-          <a href="{{github-link model.project.id model.projectVersion.version model.file model.line}}" target="_blank" rel="noopener">{{model.file}}:{{model.line}}</a>
+          <a href="{{github-link model.project.id model.projectVersion.version model.file model.line}}" target="_blank" rel="noopener noreferrer">{{model.file}}:{{model.line}}</a>
         </span>
       </div>
     {{/if}}

package.json

@@ -33,7 +33,7 @@
     "broccoli-merge-trees": "^2.0.0",
     "ember-a11y-testing": "^0.5.4",
     "ember-anchor": "^1.0.3",
-    "ember-auto-import": "^1.5.3",
+    "ember-auto-import": "1.2.21",
     "ember-cli": "~3.16.1",
     "ember-cli-app-version": "^3.2.0",
     "ember-cli-autoprefixer": "^1.0.0",

tests/acceptance/analytics-page-tracking-test.js

@@ -18,7 +18,7 @@ module('Acceptance | analytics page tracking', function(hooks) {
     const applicationRouter = this.owner.lookup('router:main');
     const metricsService = this.owner.lookup('service:metrics');
 
-    const routerTrackPageSpy = sinon.spy(applicationRouter, '_trackPage');
+    const routerTrackPageSpy = sinon.spy(applicationRouter, '__trackPage');
     const serviceTrackPageSpy = sinon.spy(metricsService, 'trackPage');
 
     await visit(pages[0]);
@@ -29,7 +29,7 @@ module('Acceptance | analytics page tracking', function(hooks) {
 
     assert.ok(
       routerTrackPageSpy.calledThrice,
-      `_trackPage() was not called 3 times it was called ${routerTrackPageSpy.callCount} times`
+      `__trackPage() was not called 3 times it was called ${routerTrackPageSpy.callCount} times`
     );
     assert.ok(
       serviceTrackPageSpy.calledThrice,

tests/integration/helpers/better-get-test.js

@@ -6,7 +6,6 @@ import hbs from 'htmlbars-inline-precompile';
 module('helper:better-get', function(hooks) {
   setupRenderingTest(hooks);
 
-  // Replace this with your real tests.
   test('should get dot separated', async function(assert) {
     let obj = {
       'Ember.Object': 'hello'
@@ -16,7 +15,7 @@ module('helper:better-get', function(hooks) {
 
     await render(hbs`{{better-get dataStructure key}}`);
 
-    assert.dom('*').hasText('hello');
+    assert.dom(this.element).hasText('hello');
   });
 
   test('should get rfc 176 module', async function(assert) {
@@ -28,6 +27,6 @@ module('helper:better-get', function(hooks) {
 
     await render(hbs`{{better-get dataStructure key}}`);
 
-    assert.dom('*').hasText('hello');
+    assert.dom(this.element).hasText('hello');
   });
 });

tests/integration/helpers/function-heading-id-test.js

@@ -11,6 +11,6 @@ module('helper:function-heading-id', function(hooks) {
 
     await render(hbs`{{function-heading-id inputValue}}`);
 
-    assert.dom('*').hasText('functions-computed');
+    assert.dom(this.element).hasText('functions-computed');
   });
 });