Merge pull request #860 from ember-learn/update-ember

update to 3.28 with ember-cli-update

Author: mansona

.eslintignore

@@ -13,6 +13,7 @@
 # misc
 /coverage/
 !.*
+.*/
 .eslintcache
 
 # ember-try

.eslintrc.js

@@ -33,17 +33,18 @@ module.exports = {
     // node files
     {
       files: [
-        '.eslintrc.js',
-        '.prettierrc.js',
-        '.template-lintrc.js',
-        'ember-cli-build.js',
-        'testem.js',
-        'run-tests.js',
-        'blueprints/*/index.js',
-        'config/**/*.js',
-        'lib/**/*.js',
-        'bin/*',
-        'server/**/*.js',
+        './.eslintrc.js',
+        './.prettierrc.js',
+        './.template-lintrc.js',
+        './ember-cli-build.js',
+        './testem.js',
+        './blueprints/*/index.js',
+        './config/**/*.js',
+        './lib/*/index.js',
+        './server/**/*.js',
+        './run-tests.js',
+        './bin/*',
+        './prember-urls.js',
       ],
       excludedFiles: ['config/deprecation-workflow.js'],
       parserOptions: {
@@ -62,5 +63,10 @@ module.exports = {
         'node/no-unpublished-require': 'off',
       },
     },
+    {
+      // Test files:
+      files: ['tests/**/*-test.{js,ts}'],
+      extends: ['plugin:qunit/recommended'],
+    },
   ],
 };

.template-lintrc.js

@@ -2,15 +2,5 @@
 'use strict';
 
 module.exports = {
-  extends: 'octane',
-  rules: {
-    'attribute-indentation': false,
-    'no-unnecessary-concat': false,
-    'no-inline-styles': false,
-    'no-curly-component-invocation': false,
-    'no-action': false,
-    quotes: false,
-    'no-link-to-positional-params': false,
-    'require-input-label': false,
-  },
+  extends: 'recommended',
 };

app/components/search-input.hbs

@@ -1,3 +1,4 @@
+{{! template-lint-disable no-action }}
 <div class='search-input'>
   <input
     id='search-input'

app/controllers/project-version.js

@@ -96,7 +96,9 @@ export default class ProjectVersionController extends Controller {
   @computed('metaStore.availableProjectVersions', 'model.project.id')
   get projectVersions() {
     const projectVersions =
-      this.metaStore.availableProjectVersions[this.model.project.get('id')];
+      this.metaStore.availableProjectVersions[
+        this.model.belongsTo('project').id()
+      ];
     let versions = projectVersions.sort((a, b) => semverCompare(b, a));
 
     versions = versions.map((version) => {

app/models/missing.js

@@ -1,6 +1,3 @@
-import Model, { attr } from '@ember-data/model';
+import Class from './class';
 
-export default class Missing extends Model {
-  @attr()
-  name;
-}
+export default class Missing extends Class {}

app/templates/ember-cli.hbs

@@ -1,3 +1,4 @@
+{{! template-lint-disable no-inline-styles }}
 {{!-- Template is copied from project-version.hbs --}}
 <aside class="sidebar">
   <ol class="toc-level-0">

app/templates/methods.hbs

@@ -1,3 +1,4 @@
+{{! template-lint-disable no-action }}
 <EmberAnchor @a={{this.anchor}} />
 <ApiIndexFilter @model={{this.model}} @filterData={{this.filterData}} as |filteredModel|>
   {{#each filteredModel.methods as |method|}}

app/templates/project-version.hbs

@@ -1,3 +1,4 @@
+{{! template-lint-disable no-inline-styles }}
 <aside class="sidebar">
   <ol class="toc-level-0">
     <li class="toc-level-0" data-test-home>

app/templates/project-version/classes/class.hbs

@@ -1,3 +1,4 @@
+{{! template-lint-disable no-action }}
 <article class="chapter">
   {{#if (is-latest version=@model.projectVersion.version allVersions=this.allVersions)}}
     <a data-tooltip="Edit on Github" class="heading__link__edit" href="{{github-link @model.project.id @model.projectVersion.version @model.file @model.line isEdit=true}}" target="_blank" rel="noopener noreferrer">{{svg-jar "fa-pencil"}}</a>

app/templates/properties.hbs

@@ -1,3 +1,4 @@
+{{! template-lint-disable no-action }}
 <EmberAnchor @a={{this.anchor}} />
 <ApiIndexFilter @model={{this.model}} @filterData={{this.filterData}} as |filteredModel|>
   {{#each filteredModel.properties as |property|}}

config/deprecation-workflow.js

@@ -1,9 +1,15 @@
 self.deprecationWorkflow = self.deprecationWorkflow || {};
 self.deprecationWorkflow.config = {
   workflow: [
-    { handler: 'silence', matchId: 'ember.globals-resolver' },
-    { handler: 'silence', matchId: 'ember-component.is-visible' },
+    { handler: 'silence', matchId: 'ember-global' },
+    { handler: 'silence', matchId: 'ember.component.reopen' },
+    { handler: 'silence', matchId: 'implicit-injections' },
     { handler: 'silence', matchId: 'manager-capabilities.modifiers-3-13' },
     { handler: 'silence', matchId: 'this-property-fallback' },
+    { handler: 'silence', matchId: 'ember-component.is-visible' },
+    {
+      handler: 'silence',
+      matchId: 'deprecated-run-loop-and-computed-dot-access',
+    },
   ],
 };

config/ember-cli-update.json

@@ -3,7 +3,7 @@
   "packages": [
     {
       "name": "ember-cli",
-      "version": "3.26.1",
+      "version": "3.28.6",
       "blueprints": [
         {
           "name": "app",

config/targets.js

@@ -7,12 +7,20 @@ const browsers = [
   'last 1 Edge versions',
 ];
 
-const isCI = Boolean(process.env.CI);
-const isProduction = process.env.EMBER_ENV === 'production';
-
-if (isCI || isProduction) {
-  browsers.push('ie 11');
-}
+// Ember's browser support policy is changing, and IE11 support will end in
+// v4.0 onwards.
+//
+// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
+//
+// If you need IE11 support on a version of Ember that still offers support
+// for it, uncomment the code block below.
+//
+// const isCI = Boolean(process.env.CI);
+// const isProduction = process.env.EMBER_ENV === 'production';
+//
+// if (isCI || isProduction) {
+//   browsers.push('ie 11');
+// }
 
 module.exports = {
   browsers,