Skip to content

Commit cf5fcd0

Browse files
authored
Merge pull request #331 from lifeart/filter-data-computed-params
Removed code duplicates for computedProperty arguments
2 parents c1bb60c + 7b3ea20 commit cf5fcd0

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

app/components/api-index-filter.js

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,33 +3,22 @@ import Component from '@ember/component';
33
import uniq from 'npm:lodash.uniq';
44
import sortBy from 'npm:lodash.sortby';
55

6+
const filterDataComputedParams = 'filterData.{showInherited,showProtected,showPrivate,showDeprecated}';
67

78
export default Component.extend({
89
classNames: ['api-index-filter'],
910

10-
filteredMethods: computed('model.methods.[]',
11-
'filterData.showInherited',
12-
'filterData.showProtected',
13-
'filterData.showPrivate',
14-
'filterData.showDeprecated',
11+
filteredMethods: computed('model.methods.[]', filterDataComputedParams,
1512
function() {
1613
return this.filterItems('methods');
1714
}),
1815

19-
filteredEvents: computed('model.events.[]',
20-
'filterData.showInherited',
21-
'filterData.showProtected',
22-
'filterData.showPrivate',
23-
'filterData.showDeprecated',
16+
filteredEvents: computed('model.events.[]', filterDataComputedParams,
2417
function() {
2518
return this.filterItems('events');
2619
}),
2720

28-
filteredProperties: computed('model.properties.[]',
29-
'filterData.showInherited',
30-
'filterData.showProtected',
31-
'filterData.showPrivate',
32-
'filterData.showDeprecated',
21+
filteredProperties: computed('model.properties.[]', filterDataComputedParams,
3322
function() {
3423
return this.filterItems('properties');
3524
}),

0 commit comments

Comments
 (0)