Fix linting and some test failures

Author: jenweber

.eslintrc.js

@@ -23,8 +23,15 @@ module.exports = {
     'ember/no-jquery': 'off',
     'no-console': 'off',
     'ember/no-new-mixins': 'off',
+    'ember/no-mixins': 'off',
     'ember/native-classes': 'off',
     'ember/require-tagless-components': 'off',
+    'ember/no-test-this-render': 'off',
+    'ember/no-classic-classes': 'off',
+    'ember/no-get': 'off',
+    'ember/no-actions-hash': 'off',
+    'ember/no-classic-components': 'off',
+    'ember/no-private-routing-service': 'off',
   },
   overrides: [
     // node files

.template-lintrc.js

@@ -11,5 +11,7 @@ module.exports = {
     'no-curly-component-invocation': false,
     'no-action': false,
     quotes: false,
+    'no-link-to-positional-params': false,
+    'require-input-label': false,
   },
 };

app/mixins/parent-name.js

@@ -4,7 +4,7 @@ import Mixin from '@ember/object/mixin';
 import { inject as service } from '@ember/service';
 
 export default Mixin.create({
-  router: service('-routing'),
+  router: service('router'),
 
   routeName: readOnly('router.currentRouteName'),
   parentName: computed('routeName', function () {

app/router.js

@@ -13,7 +13,7 @@ class AppRouter extends EmberRouter {
   constructor() {
     super(...arguments);
 
-    if (!this.get('fastboot.isFastBoot')) {
+    if (!this.fastboot.isFastBoot) {
       this.on('routeDidChange', this, this._trackPage);
     }
   }

app/routes/project-version/classes/class.js

@@ -1,6 +1,6 @@
 import { resolve, all } from 'rsvp';
 import Route from '@ember/routing/route';
-import { set, get } from '@ember/object';
+import { set } from '@ember/object';
 import ScrollTracker from 'ember-api-docs/mixins/scroll-tracker';
 import { inject as service } from '@ember/service';
 import { pluralize } from 'ember-inflector';

app/routes/project-version/functions/function.js

@@ -1,7 +1,7 @@
 import Route from '@ember/routing/route';
 import getFullVersion from 'ember-api-docs/utils/get-full-version';
 import { inject as service } from '@ember/service';
-import { get, set } from '@ember/object';
+import { set } from '@ember/object';
 import createExcerpt from 'ember-api-docs/utils/create-excerpt';
 
 export default Route.extend({
@@ -10,7 +10,7 @@ export default Route.extend({
   scrollPositionReset: service(),
 
   titleToken(model) {
-    return get(model, 'fn.name');
+    return model?.fn?.name;
   },
 
   async model(params) {

app/services/scroll-position-reset.js

@@ -5,6 +5,10 @@ import getOffset from '../utils/get-offset';
 const { scrollContainerSelector } = config.APP;
 
 export default class ScrollPositionResetService extends Service {
+  constructor() {
+    super(...arguments);
+    this._shouldResetScroll = false;
+  }
   handleScrollPosition() {
     if (
       typeof FastBoot === 'undefined' &&
@@ -62,7 +66,7 @@ export default class ScrollPositionResetService extends Service {
         selector.scrollLeft = 0;
         selector.scrollTop = 0;
       }
-      this.set('_shouldResetScroll', false);
+      this._shouldResetScroll = false;
     }
   }
 }

app/services/search.js

@@ -1,6 +1,6 @@
 import Service, { inject as service } from '@ember/service';
 import { task } from 'ember-concurrency';
-import { get, set } from '@ember/object';
+import { set } from '@ember/object';
 import { A as emberArray } from '@ember/array';
 import { alias } from '@ember/object/computed';
 

app/templates/head.hbs

@@ -7,6 +7,6 @@
   <meta name="description" content={{model.description}}>
   <meta property="og:description" content={{model.description}}>
 {{/if}}
-{{#if (not model.isRelease)}}
+{{#unless model.isRelease}}
   <link rel="canonical" href={{model.canonicalUrl}}>
-{{/if}}
+{{/unless}}

app/templates/project-version.hbs

@@ -21,6 +21,7 @@
       @ariaLabel="Select a version"
       @required={{true}}
       @searchField="compactVersion"
+      @searchEnabled={{true}}
       as |ver|
     >
       {{ver.compactVersion}}

package.json

@@ -106,7 +106,7 @@
     "normalize.css": "^8.0.1",
     "npm-run-all": "^4.1.5",
     "prettier": "^2.2.1",
-    "qunit": "^2.14.1",
+    "qunit": "^2.16.0",
     "qunit-dom": "^1.6.0",
     "sanitize-html": "^2.3.2",
     "sass": "^1.25.0",

tests/unit/utils/get-full-version-test.js

@@ -2,9 +2,7 @@ import getFullVersion from 'ember-api-docs/utils/get-full-version';
 import { module, test } from 'qunit';
 import Service from '@ember/service';
 import { A } from '@ember/array';
-import DS from 'ember-data';
-
-const { ManyArray } = DS;
+import { ManyArray } from '@ember-data/model/-private';
 
 module('Unit | Utility | get full version', function () {
   test('should return full version when release', function (assert) {

yarn.lock

@@ -9701,11 +9701,6 @@ js-base64@^2.1.8:
   resolved "https://registry.yarnpkg.com/js-base64/-/js-base64-2.6.4.tgz#f4e686c5de1ea1f867dbcad3d46d969428df98c4"
   integrity sha512-pZe//GGmwJndub7ZghVHz7vjb2LgC1m8B07Au3eYqeqv9emhESByMXxaEgkUkEqJe87oBbSniGYoQNIBklc7IQ==
 
-[email protected]:
-  version "2.0.0"
-  resolved "https://registry.yarnpkg.com/js-reporters/-/js-reporters-2.0.0.tgz#62ad6a512f1740d3ab4686b0059dd9f57cc0708b"
-  integrity sha512-VJd/86niT7GzsaVc+Yxrs8QPrYl1orzv8bYZPuSOtxU6rk/pv8aOXTcIa7HaANvtvdLMTsZspAiucNQ6T2QFHw==
-
 js-string-escape@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/js-string-escape/-/js-string-escape-1.0.1.tgz#e2625badbc0d67c7533e9edc1068c587ae4137ef"
@@ -12031,13 +12026,12 @@ qunit-dom@^1.6.0:
     ember-cli-babel "^7.23.0"
     ember-cli-version-checker "^5.1.1"
 
-qunit@^2.14.1:
-  version "2.15.0"
-  resolved "https://registry.yarnpkg.com/qunit/-/qunit-2.15.0.tgz#8ba3a3c5d13369ab1740337680600a98a7f8b591"
-  integrity sha512-9ZoOILeyRZzrdvy2m7M4S76bneGD75Bh4B2aot3uKRKZuoEvA9gevvzU339L805Ys0AN2C7cnAV9nIBD5t72IQ==
+qunit@^2.16.0:
+  version "2.16.0"
+  resolved "https://registry.yarnpkg.com/qunit/-/qunit-2.16.0.tgz#b8ed63d512e5d4eaada5afc0c6c9e8b844181ba1"
+  integrity sha512-88x9t+rRMbB6IrCIUZvYU4pJy7NiBEv7SX8jD4LZAsIj+dV+kwGnFStOmPNvqa6HM96VZMD8CIIFKH2+3qvluA==
   dependencies:
     commander "7.1.0"
-    js-reporters "2.0.0"
     node-watch "0.7.1"
     tiny-glob "0.2.8"