Handle doc lookup where id not found, and remove problematic hash-to-query addon (#592)

* Handle doc lookup where id not found, and remove problematic hash-to-query addon

* Prevent double fetch when a call find with namespace type fails

Author: toddjordan

app/adapters/application.js

@@ -34,8 +34,12 @@ export default JSONAPIAdapter.extend({
         modelNameToUse = 'namespace';
       }
 
-      let encodedRevId = encodeURIComponent(revId);
-      url = `json-docs/${projectName}/${version}/${pluralize(modelNameToUse)}/${encodedRevId}`;
+      if (typeof revId != 'undefined') {
+        let encodedRevId = encodeURIComponent(revId);
+        url = `json-docs/${projectName}/${version}/${pluralize(modelNameToUse)}/${encodedRevId}`;
+      } else {
+        throw new Error('Documentation item not found');
+      }
     } else if (modelName === 'missing') {
       let version = this.get('projectService.version');
       let revId = this.get('metaStore').getRevId(projectName, version, modelName, id);

app/routes/project-version/classes/class.js

@@ -29,10 +29,20 @@ export default Route.extend(ScrollTracker, {
 
   find(typeName, param) {
     return this.store.find(typeName, param).catch((e1) => {
-      Logger.warn(e1, 'fetching by class or module failed, retrying as namespace');
-      return this.store.find('namespace', param).catch((e2) => {
-        Logger.error(e2);
-        return resolve({ isError: true });
+      if (typeName != 'namespace') {
+        Logger.warn(e1, 'fetching by class or module failed, retrying as namespace');
+        return this.store.find('namespace', param).catch((e2) => {
+          Logger.error(e2);
+          return resolve({
+            isError: true,
+            status: 404
+          });
+        });
+      }
+      Logger.error(e1);
+      return resolve({
+        isError: true,
+        status: 404
       });
     });
   },

lib/hash-to-query/index.js

@@ -106,8 +106,5 @@
     "npm": "5"
   },
   "cacheDirectories": ["bower_components", "node_modules"],
-  "ember-addon": {
-    "paths": ["lib/hash-to-query"]
-  },
   "fastbootDependencies": ["algoliasearch"]
 }