second pass at duplicate properties bugfix (#276)

Author: jenweber

app/components/api-index-filter.js

@@ -60,21 +60,51 @@ export default Component.extend({
   }),
 
   /**
-  * Show the most local property if there are duplicate properties of the same name.
-  * The docs for the nearest inheritance are typically more helpful to users.
-  * Ember-jsonapi-docs returns a mix of inherited/local, but once sorted, the
-  * first item in the list is "most local."
+  * Returns an array where duplicate methods (by name) are removed.
+  * The docs for the nearest inheritance are typically more helpful to users,
+  * so in cases of duplicates, "more local" is preferred.
+  * Without this, multiple entries for some methods will show up.
   * @method filterMultipleInheritance
   */
   filterMultipleInheritance(items) {
-    return items.filter(function(item, index, arr) {
-      if (index === 0) {
-        return true;
-      } else if (item.name === arr[index - 1].name) {
-        return false;
+    let dedupedArray = [];
+    for (let i = 0; i < items.length; i++) {
+      let currentItem = items[i];
+      if (i === items.length - 1) {
+        // if it's the last item, keep it
+        dedupedArray.push(currentItem);
       } else {
-        return true;
+        let nextItem = items[i + 1];
+        if (currentItem.name === nextItem.name) {
+          // if the method would be listed twice, find the more local documentation
+          let mostLocal = this.findMostLocal(currentItem, nextItem)
+          dedupedArray.push(mostLocal);
+          i += 1; // skip the next item with duplicate name
+        } else {
+          dedupedArray.push(currentItem);
+        }
       }
-    })
+    }
+    return dedupedArray;
+  },
+  /**
+  * Returns whichever item is most local.
+  * What is "most local" is determined by looking at the file path for the
+  * method, the file path for the class being viewed, and the parent if needed.
+  * @method findMostLocal
+  */
+  findMostLocal(currentItem, nextItem) {
+    let currentScope = this.get('model.file');
+    let parentClassScope = this.get('model.parentClass.file');
+    if (currentScope === currentItem.file) {
+      // if the item belongs to the class, keep it
+      return currentItem;
+    } else if (parentClassScope === currentItem.file) {
+      // or if the item belongs to the parent class, keep it
+      return currentItem;
+    } else {
+      // otherwise, the next item must be "more local"
+      return nextItem;
+    }
   }
 })