Update scroll container selector #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MartinMalinda created a review app. |
|
Seems like BrowserStack does not offer free IE tests anymore. I briefly checked it on IE 11 emulator within Edge and it worked there but so did the production version. Also, the failing test seems like some super random edge case. I tried running it several time, normally and headlessly without issues. Can we merge and reopen if someone reports issues? Or let someone with Windows provide feedback also after a fix for #304 is merged? |
|
@MartinMalinda tried a restart and the failure seems to be consistent. Can you try spending some time on it? If you can't get far, I can help pitch in. |
|
But once that's done, I'm good to merge. |
MartinMalinda
force-pushed
the
scroll-container-el-fix
branch
from
6a9833d to
4092e4f
Compare
|
Turns out I just haven't committed some of the last changes :) It should pass now. |
Gaurav0
pushed a commit
to Gaurav0/ember-api-docs
that referenced
this pull request
Sep 16, 2019
Update preventing-and-retrying-transitions.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #305
I checked with Firefox ✅
Did not check with IE so far but it should work 99% (I'll check with BrowserStack if we have a PR preview URL).