feat: sticky method, property, and event headers #336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knownasilya Will this be sticky on mobile as well? |
|
Yes |
|
Fyi: the feature request has been implemented in kaliber5/ember-sticky-element#12 (though differently, as was discussed). @knownasilya please let me know in case it does not work for you as expected! |
|
Thanks for this fix, I tried this out on a few browser types and seems to work, but I'd like to use the current version of this addon (0.2.1) as it removes jquery in newer versions, plus your fix request will be implemented. @knownasilya do you have any bandwidth to update? |
|
Sure, I'll have a look today. |
|
@toddjordan should be all set. |
toddjordan
added a commit
to toddjordan/ember-api-docs
that referenced
this pull request
Aug 23, 2019
sivakumar-kailasam
added a commit
that referenced
this pull request
Aug 24, 2019
Revert "feat: sticky method, property, and event headers (#336)"
Gaurav0
pushed a commit
to Gaurav0/ember-api-docs
that referenced
this pull request
Sep 16, 2019
…d_yarn/eslint-5.11.0 Bump eslint from 5.10.0 to 5.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm 95% satisfied with this, the other 5% is if the section is really small I'd prefer not to show a sticky, but the addon just doesn't support it yet. I submitted a feature request here kaliber5/ember-sticky-element#4