Skip to content

Use styleguide navbar to make consistent with the rest of the site #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2018
Merged

Use styleguide navbar to make consistent with the rest of the site #565

merged 1 commit into from
Oct 25, 2018

Conversation

toddjordan
Copy link
Contributor

@toddjordan toddjordan commented Oct 25, 2018 •
edited
Loading

image

@toddjordan toddjordan force-pushed the use-ember-styleguide-navbar branch from 28d98fd to 7207a1a Compare October 25, 2018 02:01
@locks locks temporarily deployed to ead-review-app-pr-565 October 25, 2018 02:02 Inactive
@toddjordan toddjordan force-pushed the use-ember-styleguide-navbar branch from 7207a1a to 821a2f2 Compare October 25, 2018 03:01
@toddjordan toddjordan temporarily deployed to ead-review-app-pr-565 October 25, 2018 03:01 Inactive
@toddjordan toddjordan force-pushed the use-ember-styleguide-navbar branch from 821a2f2 to 56a28cf Compare October 25, 2018 03:19
@toddjordan toddjordan mentioned this pull request Oct 25, 2018
Closed
sivakumar-kailasam
sivakumar-kailasam approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@sivakumar-kailasam sivakumar-kailasam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably one of my favorite PRs of this year 😍

@sivakumar-kailasam sivakumar-kailasam merged commit f5ec161 into ember-learn:master Oct 25, 2018
Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this pull request Sep 16, 2019
@eflanagan0
unify code fence examples to JSON
073de48 
fix ember-learn#565. I did a quick search and didn't find other obvious examples.
There could be more and this can easily happen without automating
linting or formatting the files before a commit (prettier). See
https://github.com/ember-learn/guides-source/blob/master/extractCode.js
for initial work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sivakumar-kailasam sivakumar-kailasam sivakumar-kailasam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toddjordan @sivakumar-kailasam @locks