Skip to content

Update staging and add deploy instructions to README #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2021
Merged

Update staging and add deploy instructions to README #760

merged 3 commits into from
May 20, 2021

Conversation

amyrlam
Copy link
Member

@amyrlam amyrlam commented May 20, 2021

No description provided.

@amyrlam amyrlam requested a review from mansona May 20, 2021 04:51
@locks locks temporarily deployed to ember-api-do-amyrlam-pa-c5kpns May 20, 2021 04:53 Inactive
jenweber
jenweber reviewed May 20, 2021
View reviewed changes
jenweber
jenweber approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than linking to the deploying guide, I think this is good to go! Thank you!

@amyrlam @jenweber
Update README.md
f1516e0 
Co-authored-by: Jen Weber <[email protected]>
@amyrlam amyrlam temporarily deployed to ember-api-do-amyrlam-pa-c5kpns May 20, 2021 15:22 Inactive
@amyrlam amyrlam temporarily deployed to ember-api-do-amyrlam-pa-c5kpns May 20, 2021 15:27 Inactive
@amyrlam
Copy link
Member Author

amyrlam commented May 20, 2021

A yarn run lint passes...am confused if the CI failure (which doesn't seem to show any details?) is just an off thing, seemed slow today. Will try again later. Or if anyone has insight let me know!

@amyrlam
Copy link
Member Author

amyrlam commented May 20, 2021

I think GitHub actions was having issues, done now!

@amyrlam amyrlam merged commit 69d4c38 into master May 20, 2021
@amyrlam amyrlam deleted the amyrlam-patch-1 branch May 20, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenweber jenweber jenweber approved these changes

@mansona mansona Awaiting requested review from mansona

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyrlam @jenweber @locks