Skip to content

Remove duplicate item from Ember landing page #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Remove duplicate item from Ember landing page #770

merged 1 commit into from
Jul 22, 2021

Conversation

robertosequeira
Copy link
Contributor

@robertosequeira robertosequeira commented Jul 5, 2021

There are 2 almost similar items in the Commonly searched-for documentation section in the Ember landing page. So this PR removes the one with less information.

image

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robertosequeira
Copy link
Contributor Author

You are welcome @locks

@robertosequeira
Copy link
Contributor Author

Hello @locks, do you know what is required to move this PR on?

On my side I see this

image

But I don't even know who to ask for help

@jenweber
Copy link
Contributor

This looks good, thanks for catching it! I will merge it as soon as the tests finish.

@mansona mansona merged commit b850915 into ember-learn:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants