Skip to content

Display object properties #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 20, 2022
Merged

Conversation

sdahlbac
Copy link
Contributor

image

Not sure if this is the best way to style it, but seems to work at least.

Closes #765

@locks
Copy link
Contributor

locks commented Oct 28, 2021

Hi @sdahlbac! Can you rebase the PR so we get Percy running?

@locks locks requested a review from a team November 9, 2021 03:10
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this PR got lost in the notifications! This looks like a great improvement. I'll merge it if tests are still passing.

@jenweber
Copy link
Contributor

Thanks for your work! I click tested it locally and it's great to have this! Closes #797

@jenweber jenweber merged commit e4675f1 into ember-learn:master Apr 20, 2022
@sdahlbac sdahlbac deleted the display-props branch May 16, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documented object properties are not displayed
4 participants