Skip to content

Commit 4ed9664

Browse files
authored
Merge pull request #207 from ember-learn/deprecate-es-pagewrapper
Deprecate es pagewrapper
2 parents fce75ec + 7c523b2 commit 4ed9664

File tree

4 files changed

+16
-1
lines changed

4 files changed

+16
-1
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,5 +36,4 @@ For more information on using ember-cli, visit [https://ember-cli.com/](https://
3636
* Each component must have the component name attached to the component as a CSS class.
3737
* It may feel as though there is duplicated code throughout these components; during the WIP process, we are favoring duplication over abstraction.
3838
* Font icons through [ember-fontawesome](https://fontawesome.com/how-to-use/on-the-web/using-with/ember) - it is supported by the font awesome team and they render to SVG.
39-
* The `es-pagewrapper` component has a property to indicate if there will be a sidebar or not. There might be a better way to do this.
4039
* In this addon, the `section` element is used as a container and is intended to span the full width of the viewport.

addon/components/es-pagewrapper.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,20 @@
11
import Component from '@ember/component';
22
import layout from '../templates/components/es-pagewrapper';
33

4+
import { deprecate } from '@ember/application/deprecations';
5+
46
export default Component.extend({
57
layout,
8+
9+
init() {
10+
this._super(...arguments);
11+
12+
deprecate('es-pagewrapper is deprecated and will be removed in the next version of ember-styleguide. If you think this has been done in error please contact the Learning Team in #dev-ember-learning in the Ember Community Discord.', null, {
13+
id: 'styleguide-es-ulist',
14+
until: '4.0.0'
15+
});
16+
},
17+
618
classNameBindings: ['hasAside:pagewrapper-aside:pagewrapper'],
719
hasAside: false,
820
ariaRole: 'presentation',

tests/dummy/app/templates/docs/components/es-pagewrapper.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# Page Wrapper
22

3+
**Note: this component is deprecated and will be removed in the next version of ember-styleguide**
4+
35
{{#docs-demo as |demo|}}
46
{{#demo.example name='es-pagewrapper'}}
57
{{es-pagewrapper}}

tests/dummy/app/templates/docs/components/es-ulist.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
The list component is an unstyled, unordered list. A title must be defined, but can be visually hidden.
44

5+
**Note: this component is deprecated and will be removed in the next version of ember-styleguide**
6+
57
## Uses
68

79
### Unstyled, Unordered List

0 commit comments

Comments
 (0)