fixing padding of page-header

mansona · mansona · commit b49cfd55fa61 · 2019-04-06T21:00:18.000+01:00
diff --git a/addon/styles/components/es-page-header.css b/addon/styles/components/es-page-header.css
@@ -1,10 +1,14 @@
 .es-page-header {
-  & .container {
-    margin-top: 4.5rem;
-    margin-bottom: 4.5rem;
-    & p {
-      margin-top: 2em;
-      margin-bottom: 2em;
-    }
-  }
+  padding-top: 4.5rem;
+  padding-bottom: 4.5rem;
+}
+
+.es-page-header__title {
+  margin-top: 0;
+  margin-bottom: 0;
+}
+
+.es_page-header__details {
+  margin-top: 2em;
+  margin-bottom: 2em;
 }
diff --git a/addon/styles/global.css b/addon/styles/global.css
@@ -18,8 +18,3 @@ body {
   background-color: var(--color-dark);
   color: var(--color-light);
 }
-
-h1 {
-  margin-left: inherit;
-  margin-right: inherit;
-}
diff --git a/addon/templates/components/es-page-header.hbs b/addon/templates/components/es-page-header.hbs
@@ -1,8 +1,8 @@
 <div class="es-page-header" ...attributes>
   <div class="container">
-    <h1>{{@headline}}</h1>
+    <h1 class="es-page-header__title">{{@headline}}</h1>
 
-    <p>{{@detail}}</p>
+    <p class="es-page-header__details">{{@detail}}</p>
 
     {{yield}}
   </div>

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,3 @@ body {`
`18`	`18`	`background-color: var(--color-dark);`
`19`	`19`	`color: var(--color-light);`
`20`	`20`	`}`
`21`		`-`
`22`		`-h1 {`
`23`		`- margin-left: inherit;`
`24`		`- margin-right: inherit;`
`25`		`-}`