Skip to content

Commit d7650f2

Browse files
Merge branch 'master' into esulisttests
2 parents ca91352 + 9a8f537 commit d7650f2

File tree

13 files changed

+79
-32
lines changed

13 files changed

+79
-32
lines changed

CHANGELOG.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,16 @@
11

2+
v3.1.1 / 2019-06-24
3+
==================
4+
5+
* Fix navbar formatting #185 from @jenweber
6+
7+
v3.1.0 / 2018-06-22
8+
==================
9+
10+
* add es-section component #175 from @MelSumner
11+
* [Doc] Update the Help Wanted link in nav bar #178 from @vasind
12+
* Updated dnsimple target link in es-footer component from @sivakumar-kailasam
13+
214
v3.0.0 / 2018-05-23
315
==================
416

addon/components/es-navbar/link/template.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
>
2020
{{link.name}}
2121
</a>
22-
<ul class="dropdown" role="menu" aria-label={{link.name}}>
22+
<ul class="dropdown dropdown-menu" role="menu" aria-label={{link.name}}>
2323
{{#each link.items as |item|}}
2424
{{#if (eq item.type "link")}}
2525
<li role="none">

addon/components/es-section.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import Component from '@ember/component';
2+
import layout from '../templates/components/es-section';
3+
4+
export default Component.extend({
5+
layout
6+
});

addon/constants/es-footer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ const contributorLinks = [{
3232
}, {
3333
name: 'Resolved with:',
3434
title: "Dnsimple",
35-
href: 'https://dnsimple.com/resolving/emberjs',
35+
href: 'https://dnsimple.link/resolving-emberjs',
3636
class: 'dnsimple-logo-dark'
3737
}];
3838

addon/constants/links.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,11 @@ export default [{
2525
type: 'dropdown',
2626
items: [{
2727
href: 'https://emberjs.com/releases',
28-
name: 'Channels',
28+
name: 'Overview',
29+
type: 'link'
30+
}, {
31+
href: 'https://emberjs.com/releases/lts',
32+
name: '→ LTS',
2933
type: 'link'
3034
}, {
3135
href: 'https://emberjs.com/releases/release',
@@ -41,13 +45,17 @@ export default [{
4145
type: 'link'
4246
}, {
4347
type: 'divider'
48+
}, {
49+
href: 'https://emberjs.com/editions',
50+
name: 'Editions',
51+
type: 'link'
4452
}, {
4553
href: 'https://deprecations.emberjs.com',
4654
name: 'Deprecations',
4755
type: 'link'
4856
}, {
49-
href: 'https://emberjs.com/statusboard',
50-
name: 'Status Board',
57+
href: 'https://github.com/emberjs/rfc-tracking/issues',
58+
name: 'RFC Tracking',
5159
type: 'link'
5260
}]
5361
}, {

addon/styles/_es-navbar.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,6 @@ ul[role="menubar"] > li.dropdown > a:after {
109109
border-left: 4px solid transparent;
110110
}
111111

112-
ul[role="menubar"][aria-expanded="true"] ul[role="menu"]{
113-
top: 0 !important;
114-
}
115-
116112
ul[role="menubar"] ul[role="menu"] {
117113
display: none;
118114
width: 100%;

addon/styles/_es-section.scss

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
.es-section {
2+
3+
&.dark {
4+
background-color: $black;
5+
color: $white;
6+
}
7+
&.accent {
8+
.es-heading {
9+
color: $orange;
10+
}
11+
}
12+
}

addon/styles/addon.scss

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111
@import 'ember-bootstrap/navbar';
1212
@import 'ember-bootstrap/transitions';
1313

14+
@import 'es-accordion';
1415
@import 'es-aside';
16+
@import 'es-blog-heading';
1517
@import 'es-button';
1618
@import 'es-buttonbar';
1719
@import 'es-card';
@@ -21,10 +23,9 @@
2123
@import 'es-heading';
2224
@import 'es-main';
2325
@import 'es-navbar';
24-
@import 'es-ulist';
2526
@import 'es-note';
26-
@import 'es-accordion';
27-
@import 'es-blog-heading';
27+
@import 'es-section';
28+
@import 'es-ulist';
2829

2930
h1, h2, h3, h4, h5, h6 {
3031
-webkit-font-smoothing: antialiased;
@@ -38,24 +39,6 @@ body {
3839
color: $black;
3940
padding: 0;
4041
margin: 0;
41-
//.pagewrapper-aside {
42-
// display: grid;
43-
// grid-gap: 20px;
44-
// grid-template-areas: "header" "content" "sidebar" "footer";
45-
// @media (min-width: 600px) {
46-
// grid-template-columns: 1fr 3fr;
47-
// grid-template-areas: "header header" "sidebar content" "footer footer";
48-
// }
49-
//}
50-
//.pagewrapper {
51-
// display: grid;
52-
// grid-gap: 20px;
53-
// grid-template-areas: "header" "content" "footer";
54-
// @media (min-width: 600px) {
55-
// grid-template-columns: 1fr;
56-
// grid-template-areas: "header" "content" "footer";
57-
// }
58-
//}
5942
}
6043

6144
section {
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{{yield}}

app/components/es-section.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export { default } from 'ember-styleguide/components/es-section';

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ember-styleguide",
3-
"version": "3.0.0",
3+
"version": "3.1.1",
44
"description": "Addon to help standardize the ember family of websites",
55
"keywords": [
66
"ember-addon"
Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,4 @@
11
{{docs-header}}
2-
{{outlet}}
2+
<main>
3+
{{outlet}}
4+
</main>
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
import { module, test } from 'qunit';
2+
import { setupRenderingTest } from 'ember-qunit';
3+
import { render } from '@ember/test-helpers';
4+
import hbs from 'htmlbars-inline-precompile';
5+
6+
module('Integration | Component | es-section', function(hooks) {
7+
setupRenderingTest(hooks);
8+
9+
test('it renders', async function(assert) {
10+
// Set any properties with this.set('myProperty', 'value');
11+
// Handle any actions with this.set('myAction', function(val) { ... });
12+
13+
await render(hbs`{{es-section}}`);
14+
15+
assert.equal(this.element.textContent.trim(), '');
16+
17+
// Template block usage:
18+
await render(hbs`
19+
{{#es-section}}
20+
template block text
21+
{{/es-section}}
22+
`);
23+
24+
assert.equal(this.element.textContent.trim(), 'template block text');
25+
});
26+
});

0 commit comments

Comments
 (0)