Add closePopupMenu function to navbar service #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@patocallaghan I think it's best to come back to the testing story later. There isn't that much testing around the components in here yet and we don't need to block needed features like this while waiting for testing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @mansona offline this is required for fixing ember-learn/ember-website#151
The PR introduces a
closePopupMenumethod to thenavbarservice. This allows you to close thees-navbardropdown if it's open.I was trying to add a unit test for the new function but it wasn't straightforward. It's a bit janky as internally the
navbar#registermethod accesses the DOM which isn't available in a unit test. Any thoughts?