Tracking Branch for the Ember Website Redesign RFC #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansona
force-pushed
the
website-redesign-rfc
branch
2 times, most recently
from
0e0626e to
88c0566
Compare
mansona
force-pushed
the
website-redesign-rfc
branch
from
88c0566 to
0109d72
Compare
mansona
force-pushed
the
website-redesign-rfc
branch
from
feee86e to
d577c76
Compare
Merged
Remove tabs implementation
remove es-ulist from next version of styleguide
Resolve accessibility issues with the navbar
Optimise Ember Logo
implementing basic background shapes
improve typography and color docs
Set body and text color
Upgrade sparkles components to glimmer
|
This PR is now ready to be reviewed and merged 🎉 I have updated the description with more context for people and a comment about what should or should not be reviewed 👍 Feel free to ask me any questions you might have |
jayjayjpg
approved these changes
Apr 23, 2020
jenweber
approved these changes
Apr 23, 2020
|
Since this is already in production, I think we should merge it even if changes are needed. SemVer will help us track the work and do updates. Thanks everyone for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been tracking the work for the Ember Styleguide needed for the Website Redesign RFC. This branch has already been released as pre-releases and is in use on the Ember Website right now.
As we are moving into the next phase of the redesign project it is time to release this work as a stable release 🎉 😱
This PR is too big to review the code directly, but every change was made using a PR to this branch and each of those PRs were reviewed individually. If you would like to review this PR before we merge it then I would recommend reviewing the output by looking at the new documentation: https://deploy-preview-145--ember-styleguide.netlify.app/
After this PR is merged to master I will create a new stable release from the master branch 👍