-
-
Notifications
You must be signed in to change notification settings - Fork 86
update es-note #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update es-note #306
Conversation
d5f7ba4
to
0b73c14
Compare
@MelSumner you mentioned on #305 that I have updated this PR so that it no longer depends on the new colour pallet and we can improve the design of the |
@mansona I'll be more precise next time- I meant the one that exists now on the guides and api docs. It might be helpful to be a little more generous in interpretation, though. Concerns on this latest update:
If not, let's just add a brand border on the element. That will help it have enough color contrast to pass muster for now. |
@MelSumner so as I mentioned before, this component will need a full design review before it can be used in any project (that's why I created #307) so this PR isn't really trying to get the EsNote ready to be used anywhere. I updated the design to include the border-radius and border colour that the card uses to try and address the contrast issue (adding a brand colour was a bit too garish 🙈). If this isn't enough I'm happy to just switch it to the brand colour for now as it will be updated soon anyway 👍 |
@mansona since a11y is a hard requirement for any code to merge, let's at least make sure even the thing that is merged today is conformant. We can def iterate from there. |
@MelSumner I have bumped the border to the point that it passed the https://webaim.org/resources/contrastchecker/ 👍 I am now satisfied that this is conformant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
This is essentially a "first pass" on the es-note design
I created an issue to track the need for an update to this component: #307