You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[BUGFIX release] Ensure loader.js is transpiled via targets.
Prior to this change, the `packages/loader/lib/index.js` file was not
transpiled (at all). However, until 4a5b372 landed the file was still
authored (manually) in IE11 compliant ES5 JavaScript. Once 4a5b372
landed however (first released in 3.14.0-beta.1) it is impossible to use
the built assets in a browser that does not support `let` variable
declaration (e.g. Safari
9).
This ensures that `packages/loader/lib/index.js` passes through the same
transpilation process as the rest of the application, and (confirmed
manually) fixes the issue reported.
Ironically, our CI did not catch this issue (even though we are properly
testing in IE11) because IE11 actually supports `let` usage (with minor
caveats).
Also, since `loader.js` is the "one thing" that does not need modules
transpilation, this also adds a new argument to `transpileTree`. Most of
the time that option is `undefined` (and therefore not used at all), but
for header files we need to avoid the module wrapping.
0 commit comments